Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST: Use HEAD request to check table existence #10999

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 24, 2024

Fixes #10993

@github-actions github-actions bot added the core label Aug 24, 2024
@ebyhr ebyhr force-pushed the ebi/rest-catalog-table-exists branch 2 times, most recently from 8e2fe64 to 8e22a66 Compare August 24, 2024 08:33
@Fokko Fokko self-requested a review August 26, 2024 21:01
@ebyhr ebyhr marked this pull request as ready for review August 28, 2024 08:00
@ebyhr ebyhr force-pushed the ebi/rest-catalog-table-exists branch 2 times, most recently from 8a775da to 769df54 Compare September 24, 2024 01:54
@ebyhr
Copy link
Contributor Author

ebyhr commented Oct 23, 2024

@Fokko Gentle reminder.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr Sorry, I was out on paternity leave. This looks good to me, could you pull in the latest main branch?

@ebyhr ebyhr force-pushed the ebi/rest-catalog-table-exists branch from 769df54 to 57628ad Compare November 13, 2024 12:01
@ebyhr
Copy link
Contributor Author

ebyhr commented Nov 13, 2024

(Rebased on main without any changes)

@ebyhr ebyhr force-pushed the ebi/rest-catalog-table-exists branch from 57628ad to e54441f Compare November 14, 2024 11:48
@ebyhr
Copy link
Contributor Author

ebyhr commented Nov 14, 2024

@Fokko Thank you for your review. CI is green now.

@Fokko
Copy link
Contributor

Fokko commented Dec 2, 2024

@ebyhr Thanks, let's move this forward.

@Fokko Fokko merged commit bc36f5e into apache:main Dec 2, 2024
49 checks passed
@ebyhr ebyhr deleted the ebi/rest-catalog-table-exists branch December 2, 2024 05:29
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use HEAD operation for tableExists in REST-Catalog
3 participants