Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Use HEAD request to check if view exists #11760

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Dec 12, 2024

No description provided.

@github-actions github-actions bot added the core label Dec 12, 2024
@nastra
Copy link
Contributor Author

nastra commented Dec 12, 2024

@Fokko since you reviewed #10999 already, could you review this one please?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for adding this @nastra

Spec ref:

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test to TestRESTCatalog that makes sure the client is issuing a head request when checking if a view exists? Other than that the changes themselves look good to me

@nastra nastra force-pushed the view-exists-via-head-request branch from f0e9f50 to bc08ae4 Compare December 12, 2024 15:56
@nastra
Copy link
Contributor Author

nastra commented Dec 12, 2024

@amogh-jahagirdar good point, I've added a test to TestRESTViewCatalog as that's the more appropriate place to check this (instead of TestRESTCatalog)

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this @nastra , thanks @Fokko @ebyhr for reviewing! I'll merge when checks pass

@nastra nastra merged commit 3053540 into apache:main Dec 12, 2024
49 checks passed
@nastra nastra deleted the view-exists-via-head-request branch December 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants