-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Use HEAD request to check if view exists #11760
Conversation
5532738
to
f0e9f50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for adding this @nastra
Spec ref:
iceberg/open-api/rest-catalog-open-api.yaml
Line 1691 in 6c05f35
head: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test to TestRESTCatalog
that makes sure the client is issuing a head request when checking if a view exists? Other than that the changes themselves look good to me
f0e9f50
to
bc08ae4
Compare
@amogh-jahagirdar good point, I've added a test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.