HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime() #2923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@tasanuma could you please take a look? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@aajisaka would you like to take a look? |
virajjasani
commented
Apr 19, 2021
Comment on lines
690
to
691
| // set max iteration time to 500 ms to timeout before moving any block | ||
| conf.setLong(DFSConfigKeys.DFS_BALANCER_MAX_ITERATION_TIME_KEY, 500L); |
There was a problem hiding this comment.
This is the only difference to de-flake testMaxIterationTime() in this PR. Rest are test splitting changes.
tasanuma
reviewed
Apr 19, 2021
Comment on lines
726
to
729
| // Since no block cannot be moved in 2 seconds (i.e., | ||
| // 4MB/s * 2s = 8MB < 10MB), NO_MOVE_PROGRESS will be reported. | ||
| // When a block move is not canceled in 2 seconds properly and then | ||
| // a block is moved unexpectedly, IN_PROGRESS will be reported. |
There was a problem hiding this comment.
Now we have updated the parameter, should we update the comments here?
There was a problem hiding this comment.
Oh yes, missed that. Thanks @tasanuma
|
We can remove |
virajjasani
commented
Apr 19, 2021
Comment on lines
726
to
729
| // Since no block cannot be moved in 2 seconds (i.e., | ||
| // 4MB/s * 2s = 8MB < 10MB), NO_MOVE_PROGRESS will be reported. | ||
| // When a block move is not canceled in 2 seconds properly and then | ||
| // a block is moved unexpectedly, IN_PROGRESS will be reported. |
There was a problem hiding this comment.
Oh yes, missed that. Thanks @tasanuma
|
Thanks for updating it. +1, pending Jenkins. |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
reviewed
Apr 20, 2021
| /** | ||
| * Some long running Balancer tasks. | ||
| */ | ||
| public class TestBalancer2 { |
There was a problem hiding this comment.
Would you rename the class to describe the test cases, such as TestBalancerLongRunningTasks?
There was a problem hiding this comment.
Thanks @aajisaka. Done.
|
💔 -1 overall
This message was automatically generated. |
tasanuma
approved these changes
Apr 20, 2021
|
branch-3.3 backport requires very minor change. Shall I create backport PR once this is merged? |
Yes, please. Thanks! |
This was referenced Apr 21, 2021
|
Merged. Thanks for your contribution, @virajjasani. Thanks for your review, @aajisaka. I will review for the PRs for other branches. |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…pache#2923) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.