Skip to content

Commit 9d4825b

Browse files
committed
addressing comments
1 parent 749aa4f commit 9d4825b

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ public void shutdown() throws Exception {
169169
static final double CAPACITY_ALLOWED_VARIANCE = 0.005; // 0.5%
170170
static final double BALANCE_ALLOWED_VARIANCE = 0.11; // 10%+delta
171171
static final int DEFAULT_BLOCK_SIZE = 100;
172-
static final int DEFAULT_RAM_DISK_BLOCK_SIZE = 5 * 1024 * 1024;
173172
private static final Random r = new Random();
174173

175174
static {

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer2.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -723,10 +723,12 @@ public void testMaxIterationTime() throws Exception {
723723
LOG.info("NNC to work on: " + nnc);
724724
Balancer b = new Balancer(nnc, bParams, conf);
725725
Balancer.Result r = b.runOneIteration();
726-
// Since no block cannot be moved in 2 seconds (i.e.,
727-
// 4MB/s * 2s = 8MB < 10MB), NO_MOVE_PROGRESS will be reported.
728-
// When a block move is not canceled in 2 seconds properly and then
729-
// a block is moved unexpectedly, IN_PROGRESS will be reported.
726+
// Since no block can be moved in 500 milli-seconds (i.e.,
727+
// 4MB/s * 0.5s = 2MB < 10MB), NO_MOVE_PROGRESS will be reported.
728+
// When a block move is not canceled in 500 ms properly
729+
// (highly unlikely) and then a block is moved unexpectedly,
730+
// IN_PROGRESS will be reported. This is highly unlikely unexpected
731+
// case. See HDFS-15989.
730732
assertEquals("We expect ExitStatus.NO_MOVE_PROGRESS to be reported.",
731733
ExitStatus.NO_MOVE_PROGRESS, r.getExitStatus());
732734
assertEquals(0, r.getBlocksMoved());

0 commit comments

Comments
 (0)