Skip to content

HDFS-15989. Split TestBalancer and De-flake testMaxIterationTime() #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Apr 21, 2021

branch-3.3 backport of PR #2923

Signed-off-by: Akira Ajisaka aajisaka@apache.org
Signed-off-by: Takanobu Asanuma tasanuma@apache.org

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 33m 20s branch-3.3 passed
+1 💚 compile 1m 12s branch-3.3 passed
+1 💚 checkstyle 0m 53s branch-3.3 passed
+1 💚 mvnsite 1m 28s branch-3.3 passed
+1 💚 javadoc 1m 22s branch-3.3 passed
+1 💚 spotbugs 3m 15s branch-3.3 passed
+1 💚 shadedclient 18m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 10s the patch passed
+1 💚 compile 1m 7s the patch passed
+1 💚 javac 1m 7s hadoop-hdfs-project_hadoop-hdfs generated 0 new + 537 unchanged - 1 fixed = 537 total (was 538)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 38s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 149 unchanged - 49 fixed = 159 total (was 198)
+1 💚 mvnsite 1m 12s the patch passed
+1 💚 javadoc 1m 16s the patch passed
+1 💚 spotbugs 3m 14s the patch passed
+1 💚 shadedclient 17m 48s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 195m 35s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
280m 54s
Reason Tests
Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
hadoop.hdfs.TestMaintenanceState
hadoop.hdfs.TestReconstructStripedFileWithValidator
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
hadoop.hdfs.TestDecommissionWithStriped
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2942/1/artifact/out/Dockerfile
GITHUB PR #2942
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux b29dc9edf09f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 568b575
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2942/1/testReport/
Max. process+thread count 3572 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2942/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma
Copy link
Member

@virajjasani Thanks for the PRs. Could you remove unused imports in TestBalancerLongRunningTasks? There are the same unused imports in the PRs for branch-3.2 and branch-3.1. The others look good to me.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 34m 37s branch-3.3 passed
+1 💚 compile 1m 15s branch-3.3 passed
+1 💚 checkstyle 0m 48s branch-3.3 passed
+1 💚 mvnsite 1m 21s branch-3.3 passed
+1 💚 javadoc 1m 25s branch-3.3 passed
+1 💚 spotbugs 3m 8s branch-3.3 passed
+1 💚 shadedclient 17m 58s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 15s the patch passed
+1 💚 compile 1m 8s the patch passed
+1 💚 javac 1m 8s hadoop-hdfs-project_hadoop-hdfs generated 0 new + 537 unchanged - 1 fixed = 537 total (was 538)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 41s /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 149 unchanged - 49 fixed = 156 total (was 198)
+1 💚 mvnsite 1m 17s the patch passed
+1 💚 javadoc 1m 20s the patch passed
+1 💚 spotbugs 3m 7s the patch passed
+1 💚 shadedclient 17m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 188m 20s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
294m 18s
Reason Tests
Failed junit tests hadoop.hdfs.TestReconstructStripedFileWithValidator
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.server.balancer.TestBalancer
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2942/2/artifact/out/Dockerfile
GITHUB PR #2942
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 3df541248b1b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 974bbc8
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2942/2/testReport/
Max. process+thread count 3560 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2942/2/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma
Copy link
Member

I confirmed TestBalancer and TestBalancerLongRunningTasks succeeded in my local environment.

@tasanuma tasanuma merged commit 96a1dfa into apache:branch-3.3 Apr 23, 2021
@tasanuma
Copy link
Member

Merged. Thanks, @virajjasani!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants