HADOOP-16870. Use spotbugs-maven-plugin instead of findbugs-maven-plugin #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
@aajisaka commands of spotbugs installed in Docker container do not have x permission. Could this cause any problem? |
|
💔 -1 overall
This message was automatically generated. |
Yes, it caused errors https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2454/2/console I'll fix it. Thank you. |
goiri
approved these changes
Nov 12, 2020
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| package org.apache.hadoop.conf; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This change is to run spotbugs check in the precommit Jenkins job. Yes, I'll commit after reverting this.
dev-support/docker/Dockerfile
Outdated
| @@ -92,6 +92,15 @@ ENV MAVEN_HOME /usr | |||
| ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64 | |||
| ENV FINDBUGS_HOME /usr | |||
|
|
|||
| ####### | |||
| # Install SpotBugs 4.1.3 | |||
There was a problem hiding this comment.
Any chance we can make this version number a variables so we keep it consistent with the one in the pom.xml?
There was a problem hiding this comment.
I want to make this version number a variable but I don't know how to do this. The Dockerfile itself can be used from many places (start-build-env.sh, Jenkins precommit job, qbt job, ...), so I don't think we can use a variable.
aajisaka
force-pushed
the
HADOOP-16870
branch
from
cdcfa18 to
36b7dbb
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
iwasakims
reviewed
Nov 18, 2020
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
happy for this to go in once it's rebased and yetus is quiet again |
aajisaka
force-pushed
the
HADOOP-16870
branch
from
b90fd98 to
cc780b6
Compare
|
(!) A patch to the testing environment has been detected. |
aajisaka
force-pushed
the
HADOOP-16870
branch
from
630df96 to
12696e4
Compare
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This reverts commit 32e81cc.
|
(!) A patch to the testing environment has been detected. |
dineshchitlangia
approved these changes
Feb 14, 2021
|
Merged. Thank you for your review, @iwasakims @goiri, and @dineshchitlangia. |
tomscut
pushed a commit
to tomscut/hadoop
that referenced
this pull request
Feb 18, 2021
…gin (apache#2454) Use spotbugs instead of findbugs. Removed findbugs from the hadoop build images, and added spotbugs in the images instead. Reviewed-by: Masatake Iwasaki <iwasakims@apache.org> Reviewed-by: Inigo Goiri <inigoiri@apache.org> Reviewed-by: Dinesh Chitlangia <dineshc@apache.org>
|
Reverted because of the build failure in #2701 |
kiran-maturi
pushed a commit
to kiran-maturi/hadoop
that referenced
this pull request
Nov 24, 2021
…aven-plugin (apache#2454)" This reverts commit 4cf3531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HADOOP-16870
mvn compile spotbugs:spotbugsfrom project root. Without this change, the command fails by NoPluginFoundForPrefixException: