HDFS-15808. Add metrics for FSNamesystem read/write lock hold long time #2668

tomscut · 2021-02-01T12:42:38Z

JIRA: https://issues.apache.org/jira/browse/HDFS-15808

To monitor how often read/write locks exceed thresholds, we can add two metrics(ReadLockWarning/WriteLockWarning), which are exposed in JMX.

hadoop-yetus · 2021-02-01T17:25:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 52s		trunk passed
+1 💚	compile	1m 22s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	checkstyle	1m 2s		trunk passed
+1 💚	mvnsite	1m 25s		trunk passed
+1 💚	shadedclient	16m 23s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 58s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 26s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+0 🆗	spotbugs	3m 19s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 17s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 11s		the patch passed
+1 💚	compile	1m 15s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 15s		the patch passed
+1 💚	compile	1m 12s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	javac	1m 12s		the patch passed
-0 ⚠️	checkstyle	1m 1s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 165 unchanged - 0 fixed = 173 total (was 165)
+1 💚	mvnsite	1m 12s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 21s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 48s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 27s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
+1 💚	findbugs	3m 18s		the patch passed
			_ Other Tests _
-1 ❌	unit	193m 50s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		281m 31s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/1/artifact/out/Dockerfile
GITHUB PR	#2668
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux a123314fa64f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `115623a`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/1/testReport/
Max. process+thread count	3065 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-02-02T08:21:38Z

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Sorry. I didn't update those two unit tests, and they worked fine locally.

tomscut · 2021-02-09T02:18:24Z

@xkrogen
Hi Erik, could you please review the code? Thanks a lot!

…DFS-15808

hadoop-yetus · 2021-02-12T15:04:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	33m 16s		trunk passed
+1 💚	compile	1m 25s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 17s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 25s		trunk passed
+1 💚	shadedclient	16m 35s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 54s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 24s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	3m 8s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 6s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 13s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 13s		the patch passed
+1 💚	compile	1m 5s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 5s		the patch passed
-0 ⚠️	checkstyle	0m 57s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 167 unchanged - 0 fixed = 175 total (was 167)
+1 💚	mvnsite	1m 12s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 7s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 54s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 25s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	3m 12s		the patch passed
			_ Other Tests _
-1 ❌	unit	192m 53s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		280m 44s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/2/artifact/out/Dockerfile
GITHUB PR	#2668
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4e47b5746c6d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f9a073c`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/2/testReport/
Max. process+thread count	3398 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-12T15:18:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	14m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 7s		trunk passed
+1 💚	compile	1m 20s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 14s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 20s		trunk passed
+1 💚	shadedclient	15m 32s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 56s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 25s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	3m 5s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 3s		trunk passed
-0 ⚠️	patch	3m 21s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s		the patch passed
+1 💚	compile	1m 11s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 11s		the patch passed
+1 💚	compile	1m 6s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 6s		the patch passed
-0 ⚠️	checkstyle	0m 57s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 167 unchanged - 0 fixed = 175 total (was 167)
+1 💚	mvnsite	1m 11s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	12m 55s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 48s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 17s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	3m 2s		the patch passed
			_ Other Tests _
-1 ❌	unit	190m 34s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		289m 36s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/3/artifact/out/Dockerfile
GITHUB PR	#2668
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 15073fe6c019 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f9a073c`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/3/testReport/
Max. process+thread count	3120 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/3/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-02-13T00:25:15Z

Failed junit tests | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Sorry. I didn't update this unit tests, and they worked fine locally.

hadoop-yetus · 2021-02-15T16:28:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 39s		trunk passed
+1 💚	compile	1m 20s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 13s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 3s		trunk passed
+1 💚	mvnsite	1m 19s		trunk passed
+1 💚	shadedclient	15m 56s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 27s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	3m 6s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 4s		trunk passed
-0 ⚠️	patch	3m 22s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
+1 💚	compile	1m 16s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 16s		the patch passed
+1 💚	compile	1m 7s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 7s		the patch passed
+1 💚	checkstyle	0m 58s		the patch passed
+1 💚	mvnsite	1m 14s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 4s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 50s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 20s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	3m 9s		the patch passed
			_ Other Tests _
-1 ❌	unit	194m 59s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 44s		The patch does not generate ASF License warnings.
		281m 25s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/4/artifact/out/Dockerfile
GITHUB PR	#2668
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0c1c25c99215 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c3134ab`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/4/testReport/
Max. process+thread count	3175 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/4/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-02-15T16:54:00Z

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

Those failed unit tests are unrelated to the change.

...oject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystemLock.java

hadoop-yetus · 2021-02-17T01:59:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	19m 14s		Docker mode activated.
-1 ❌	yetus	0m 6s		Unprocessed flag(s): --findbugs-strict-precheck

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/5/artifact/out/Dockerfile
GITHUB PR	#2668
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/5/console
versions	git=2.25.1
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

shvachko · 2021-02-18T20:18:20Z

Just reposting my comment from the jira for visibility.

The patch looks fine, but I doubt the metric will be useful in its current form. Monotonically increasing counter doesn't tell you much when plotted. Over time it just becomes an incredibly large number, hard to see its fluctuations. And you cannot set alerts if the threshold is exceeded often.
See e.g. ExpiredHeartbeats or LastWrittenTransactionId - not useful.
I assume you need something like a rate.

tomscut · 2021-02-19T01:57:26Z

Just reposting my comment from the jira for visibility.

The patch looks fine, but I doubt the metric will be useful in its current form. Monotonically increasing counter doesn't tell you much when plotted. Over time it just becomes an incredibly large number, hard to see its fluctuations. And you cannot set alerts if the threshold is exceeded often.
See e.g. ExpiredHeartbeats or LastWrittenTransactionId - not useful.
I assume you need something like a rate.

Hey @shvachko , thank you for your comments and suggestions. I replied to you in JIRA.

hadoop-yetus · 2021-02-20T07:25:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 53s		trunk passed
+1 💚	compile	1m 20s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 15s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 22s		trunk passed
+1 💚	shadedclient	15m 17s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 58s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 28s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	3m 7s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 5s		trunk passed
-0 ⚠️	patch	3m 24s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 16s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 10s		the patch passed
+1 💚	compile	1m 6s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	1m 6s		the patch passed
+1 💚	checkstyle	0m 55s		the patch passed
+1 💚	mvnsite	1m 11s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 47s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 58s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 39s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	3m 57s		the patch passed
			_ Other Tests _
-1 ❌	unit	204m 49s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		312m 18s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.hdfs.qjournal.server.TestJournalNodeSync
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.server.datanode.TestBlockScanner

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/6/artifact/out/Dockerfile
GITHUB PR	#2668
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6ac55fde21d0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4891e68`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/6/testReport/
Max. process+thread count	3046 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2668/6/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-02-23T01:26:35Z

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestHAAppend
hadoop.hdfs.qjournal.server.TestJournalNodeSync
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.datanode.TestBlockScanner

Those failed unit tests were unrelated to the change. And they worked fine locally.

tomscut · 2021-03-01T03:25:48Z

Hi @anuengineer , could you please review again? Let's see if there are any other questions. Thank you.

tomscut · 2021-03-01T15:58:02Z

Hi @arp7 , could you take a quick look at this? Let's see if there are any other questions. Thank you.

dineshchitlangia

+1 LGTM

tomscut · 2021-03-03T06:55:17Z

Hi @shvachko , I uploaded a patch for branch-3.3 in JIRA.

+1 LGTM

Thanks @dineshchitlangia for the review.

tomscut · 2021-03-04T02:28:34Z

Hi @shvachko , I uploaded a patch for branch-3.3 in JIRA, please help to review it. Thank you.

…me. (#2668) Contributed by tomscut.

…me. (#2668) Contributed by tomscut. (cherry picked from commit 9cb51bf)

tomscut · 2021-03-13T07:38:27Z

Close this PR because the associated patch has been merged.

…me. (apache#2668) Contributed by tomscut.

Add metrics for FSNamesystem read/write lock warnings

7e16608

tomscut changed the title ~~HDFS-15808. Add metrics for FSNamesystem read/write lock warnings~~ HDFS-15808. Add metrics for FSNamesystem read/write lock hold long time Feb 12, 2021

tomscut added 3 commits February 12, 2021 18:21

update metric name

9f67ff4

Add metrics for FSNamesystem read/write lock warnings

e8632bc

Merge branch 'HDFS-15808' of https://github.com/tomscut/hadoop into H…

db5edd2

…DFS-15808

adjust for checkstyle

7ce818c

anuengineer reviewed Feb 16, 2021

View reviewed changes

...oject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystemLock.java Outdated Show resolved Hide resolved

using incrementAndGet instead of addAndGet

f3b9145

update metric annotation, add metric type=Type.COUNTER

4587b52

dineshchitlangia approved these changes Mar 3, 2021

View reviewed changes

asfgit pushed a commit that referenced this pull request Mar 6, 2021

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long ti…

9cb51bf

…me. (#2668) Contributed by tomscut.

asfgit pushed a commit that referenced this pull request Mar 6, 2021

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long ti…

c498ef4

…me. (#2668) Contributed by tomscut. (cherry picked from commit 9cb51bf)

asfgit pushed a commit that referenced this pull request Mar 6, 2021

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long ti…

03ac2e4

…me. (#2668) Contributed by tomscut. (cherry picked from commit 9cb51bf)

asfgit pushed a commit that referenced this pull request Mar 6, 2021

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long ti…

7b925bc

…me. (#2668) Contributed by tomscut. (cherry picked from commit 9cb51bf)

asfgit pushed a commit that referenced this pull request Mar 6, 2021

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long ti…

68cccba

…me. (#2668) Contributed by tomscut. (cherry picked from commit 9cb51bf)

dineshchitlangia requested a review from anuengineer March 11, 2021 04:13

tomscut closed this Mar 13, 2021

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long ti…

c741aa7

…me. (apache#2668) Contributed by tomscut.

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long time #2668

HDFS-15808. Add metrics for FSNamesystem read/write lock hold long time #2668

Uh oh!

Conversation

tomscut commented Feb 1, 2021

Uh oh!

hadoop-yetus commented Feb 1, 2021

Uh oh!

tomscut commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomscut commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Feb 12, 2021

Uh oh!

hadoop-yetus commented Feb 12, 2021

Uh oh!

tomscut commented Feb 13, 2021

Uh oh!

hadoop-yetus commented Feb 15, 2021

Uh oh!

tomscut commented Feb 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

shvachko commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomscut commented Feb 19, 2021

Uh oh!

hadoop-yetus commented Feb 20, 2021

Uh oh!

tomscut commented Feb 23, 2021

Uh oh!

tomscut commented Mar 1, 2021

Uh oh!

tomscut commented Mar 1, 2021

Uh oh!

dineshchitlangia left a comment

Choose a reason for hiding this comment

Uh oh!

tomscut commented Mar 3, 2021

Uh oh!

tomscut commented Mar 4, 2021

Uh oh!

tomscut commented Mar 13, 2021

Uh oh!

Uh oh!

tomscut commented Feb 2, 2021 •

edited

Loading

tomscut commented Feb 9, 2021 •

edited

Loading

tomscut commented Feb 15, 2021 •

edited

Loading

shvachko commented Feb 18, 2021 •

edited

Loading