HADOOP-17528. SFTP File System: close the connection pool when closing a FileSystem #2701

mpryahin · 2021-02-15T06:33:11Z

SFTPFileSystem leverages a connection pool which is not closed when a file system instance gets closed preventing a JVM from exiting as every established SFTP connection runs in a separate non-daemon thread. This PR fixes SFTPFileSystem closure.

hadoop-yetus · 2021-02-15T09:29:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 9s		trunk passed
+1 💚	compile	20m 28s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 45s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 31s		trunk passed
+1 💚	shadedclient	16m 1s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 5s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 36s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	2m 21s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 19s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	20m 33s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	20m 33s		the patch passed
+1 💚	compile	17m 53s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	17m 53s		the patch passed
+1 💚	checkstyle	1m 3s		the patch passed
+1 💚	mvnsite	1m 28s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 27s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 4s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 30s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	2m 22s		the patch passed
			_ Other Tests _
+1 💚	unit	17m 18s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 50s		The patch does not generate ASF License warnings.
		175m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/1/artifact/out/Dockerfile
GITHUB PR	#2701
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 937d084d102c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c3134ab`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/1/testReport/
Max. process+thread count	2197 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

steveloughran

LGTM, just added a little bit of extra homework on the test case so we get the full due diligence on that close() call done. thanks

...common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java

hadoop-yetus · 2021-02-17T14:30:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	14m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 27s		trunk passed
+1 💚	compile	20m 30s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 48s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 30s		trunk passed
+1 💚	shadedclient	16m 0s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 4s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 37s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	21m 5s		Both FindBugs and SpotBugs are enabled, using SpotBugs.
+1 💚	spotbugs	2m 23s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 54s		the patch passed
+1 💚	compile	19m 53s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	19m 53s		the patch passed
+1 💚	compile	17m 51s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	17m 51s		the patch passed
+1 💚	checkstyle	1m 4s		the patch passed
+1 💚	mvnsite	1m 29s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 17s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 1s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 37s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌	spotbugs	2m 17s	/patch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs
			_ Other Tests _
+1 💚	unit	17m 9s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		188m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/2/artifact/out/Dockerfile
GITHUB PR	#2701
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle
uname	Linux 44c4dabf0b93 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0ed9e36`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/2/testReport/
Max. process+thread count	1853 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

…17528

hadoop-yetus · 2021-02-17T20:09:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 50s		trunk passed
+1 💚	compile	20m 35s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	17m 52s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 29s		trunk passed
+1 💚	shadedclient	16m 5s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 4s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 35s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	21m 3s		Both FindBugs and SpotBugs are enabled, using SpotBugs.
+1 💚	spotbugs	2m 18s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 51s		the patch passed
+1 💚	compile	19m 52s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	19m 52s		the patch passed
+1 💚	compile	17m 49s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	17m 49s		the patch passed
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	1m 31s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 1s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 6s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 39s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
-1 ❌	spotbugs	2m 18s	/patch-spotbugs-hadoop-common-project_hadoop-common.txt	hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs
			_ Other Tests _
+1 💚	unit	17m 22s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 56s		The patch does not generate ASF License warnings.
		175m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/3/artifact/out/Dockerfile
GITHUB PR	#2701
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle
uname	Linux 1b80d25539dd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `0ed9e36`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/3/testReport/
Max. process+thread count	3158 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

mpryahin · 2021-02-18T06:26:01Z

@steveloughran
The build reports a problem due to the spotbugs issue
Here's a stacktrace from the build logs:

[2021-02-17T19:50:51.359Z] Building spotbugs database(s) using /opt/spotbugs for executables.
[2021-02-17T19:50:51.359Z] 
[2021-02-17T19:50:51.359Z] 
[2021-02-17T19:50:51.359Z] Starting with /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2701/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.xml
[2021-02-17T19:50:51.359Z] Exception in thread "main" java.lang.UnsupportedOperationException
[2021-02-17T19:50:51.359Z] 	at java.util.Collections$UnmodifiableCollection.removeIf(Collections.java:1086)
[2021-02-17T19:50:51.359Z] 	at edu.umd.cs.findbugs.BugRanker.trimToMaxRank(BugRanker.java:322)
[2021-02-17T19:50:51.359Z] 	at edu.umd.cs.findbugs.workflow.Update.discardUnwantedBugs(Update.java:337)
[2021-02-17T19:50:51.359Z] 	at edu.umd.cs.findbugs.workflow.Update.doit(Update.java:484)
[2021-02-17T19:50:51.359Z] 	at edu.umd.cs.findbugs.workflow.Update.main(Update.java:405)
[2021-02-17T19:50:51.359Z] 
[2021-02-17T19:50:51.359Z] hadoop-common-project/hadoop-common cannot run computeBugHistory from spotbugs

Here's a cause for this to happen.

This happened straight after substituting findbugs with spotbugs here

@aajisaka could you please help to fix the build?

aajisaka · 2021-02-19T02:08:27Z

Thank you @mpryahin for your report. I'll revert #2454 shortly.

aajisaka · 2021-02-19T02:12:10Z

Reverted #2454

…17528

hadoop-yetus · 2021-02-19T08:05:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	15m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 59s		trunk passed
+1 💚	compile	23m 10s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	20m 23s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 33s		trunk passed
+1 💚	shadedclient	16m 21s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 3s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 33s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	2m 23s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 21s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 57s		the patch passed
+1 💚	compile	21m 36s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	21m 36s		the patch passed
+1 💚	compile	19m 35s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	19m 35s		the patch passed
+1 💚	checkstyle	1m 2s		the patch passed
+1 💚	mvnsite	1m 23s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	13m 7s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 4s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 35s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	2m 38s		the patch passed
			_ Other Tests _
+1 💚	unit	17m 41s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 53s		The patch does not generate ASF License warnings.
		202m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/4/artifact/out/Dockerfile
GITHUB PR	#2701
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux bf626a3dc6fd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9a298d1`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/4/testReport/
Max. process+thread count	3158 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/4/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-02-19T09:44:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 56s		trunk passed
+1 💚	compile	23m 27s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	compile	22m 29s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	checkstyle	1m 13s		trunk passed
+1 💚	mvnsite	1m 44s		trunk passed
+1 💚	shadedclient	20m 34s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 8s		trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 48s		trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+0 🆗	spotbugs	3m 0s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 56s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s		the patch passed
+1 💚	compile	26m 48s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javac	26m 48s		the patch passed
+1 💚	compile	23m 11s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	javac	23m 11s		the patch passed
+1 💚	checkstyle	1m 12s		the patch passed
+1 💚	mvnsite	1m 44s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	17m 19s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 6s		the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 47s		the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚	findbugs	2m 57s		the patch passed
			_ Other Tests _
+1 💚	unit	18m 38s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 55s		The patch does not generate ASF License warnings.
		207m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/5/artifact/out/Dockerfile
GITHUB PR	#2701
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ec4ed8bbbc80 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `25af890`
Default Java	Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/5/testReport/
Max. process+thread count	1389 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2701/5/console
versions	git=2.25.1 maven=3.6.3 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

mpryahin · 2021-02-19T10:02:15Z

@aajisaka thanks you so much.
@steveloughran Steve, looking forward to getting the changes in, thank you.

steveloughran · 2021-02-23T17:03:43Z

+1, merged to trunk

…g a FileSystem (#2701) Contributed by Mike Pryakhin. Change-Id: I59ef67c38c313f30c5e000b2fe41fcf715cf3a4b

…g a FileSystem (apache#2701) Contributed by Mike Pryakhin.

mpryahin added 4 commits February 14, 2021 00:27

HADOOP-17528 fix SFTP file system not being properly closed

98d53c0

HADOOP-17528 fix imports

1352273

HADOOP-17528 fix imports

7ac95d8

HADOOP-17528 check if a file system is closed

ca2e5a4

steveloughran reviewed Feb 16, 2021

View reviewed changes

...common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java Show resolved Hide resolved

HADOOP-17528. Making sure that re-entrant close calls are safe.

c485b39

Merge branch 'trunk' of https://github.com/apache/hadoop into HADOOP-…

8cb5488

…17528

aajisaka mentioned this pull request Feb 19, 2021

HADOOP-16870. Use spotbugs-maven-plugin instead of findbugs-maven-plugin #2454

Merged

Merge branch 'trunk' of https://github.com/apache/hadoop into HADOOP-…

3dd93cd

…17528

steveloughran changed the title ~~HADOOP-17528. Fix closing an underlying connection pool when closing SFTP File System~~ HADOOP-17528. SFTP File System: close the connection pool when closing a FileSystem Feb 23, 2021

steveloughran merged commit 7b7c001 into apache:trunk Feb 23, 2021

asfgit pushed a commit that referenced this pull request Mar 9, 2021

HADOOP-17528. SFTP File System: close the connection pool when closin…

5ffcee8

…g a FileSystem (#2701) Contributed by Mike Pryakhin. Change-Id: I59ef67c38c313f30c5e000b2fe41fcf715cf3a4b

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021

HADOOP-17528. SFTP File System: close the connection pool when closin…

6c62796

…g a FileSystem (apache#2701) Contributed by Mike Pryakhin.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-17528. SFTP File System: close the connection pool when closing a FileSystem #2701

HADOOP-17528. SFTP File System: close the connection pool when closing a FileSystem #2701

Uh oh!

mpryahin commented Feb 15, 2021

Uh oh!

hadoop-yetus commented Feb 15, 2021

Uh oh!

steveloughran left a comment

Uh oh!

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

mpryahin commented Feb 18, 2021 •

edited

Loading

Uh oh!

aajisaka commented Feb 19, 2021

Uh oh!

aajisaka commented Feb 19, 2021

Uh oh!

hadoop-yetus commented Feb 19, 2021

Uh oh!

hadoop-yetus commented Feb 19, 2021

Uh oh!

mpryahin commented Feb 19, 2021

Uh oh!

steveloughran commented Feb 23, 2021

Uh oh!

Uh oh!

HADOOP-17528. SFTP File System: close the connection pool when closing a FileSystem #2701

HADOOP-17528. SFTP File System: close the connection pool when closing a FileSystem #2701

Uh oh!

Conversation

mpryahin commented Feb 15, 2021

Uh oh!

hadoop-yetus commented Feb 15, 2021

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

hadoop-yetus commented Feb 17, 2021

Uh oh!

mpryahin commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aajisaka commented Feb 19, 2021

Uh oh!

aajisaka commented Feb 19, 2021

Uh oh!

hadoop-yetus commented Feb 19, 2021

Uh oh!

hadoop-yetus commented Feb 19, 2021

Uh oh!

mpryahin commented Feb 19, 2021

Uh oh!

steveloughran commented Feb 23, 2021

Uh oh!

Uh oh!

mpryahin commented Feb 18, 2021 •

edited

Loading