Fix RAT check #652
Merged
Fix RAT check #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
Jul 3, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
Thanks a lot, @alamb !
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The RAT check seems to be broken (see #651 for an example PR which should have failed). Possibly related to #580
Changes
Port the changes from @jorgecarleitao in apache/arrow-rs#482 to this repo
Here is an example showing the RAT check working (catching a violation) in my own fork: alamb#2