Skip to content

Unvendor archery, clean up old files in dev #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2021
Merged

Unvendor archery, clean up old files in dev #580

merged 1 commit into from
Jun 29, 2021

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Jun 18, 2021 •
edited
Loading

Which issue does this PR close?

Closes #.

following the changes at apache/arrow-rs#459

Rationale for this change

install https://arrow.apache.org/docs/developers/archery.html from GitHub repo

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #580 (90799c9) into master (51e5445) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files         156      156           
  Lines       27063    27063           
=======================================
  Hits        20575    20575           
  Misses       6488     6488

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e5445...90799c9. Read the comment docs.

@jimexist jimexist force-pushed the unvendor-archery branch 3 times, most recently from 590b85d to 9361e01 Compare June 21, 2021 03:31
@jimexist jimexist marked this pull request as ready for review June 21, 2021 09:28
@alamb
Copy link
Contributor

alamb commented Jun 22, 2021

This may also need this change: https://github.com/apache/arrow-rs/pull/482/files (as apparently the apache licence header check / RAT was calling archery)

@alamb alamb added the development-process Related to development process of DataFusion label Jun 23, 2021
@alamb alamb force-pushed the unvendor-archery branch from cb0560b to 0f311e5 Compare June 23, 2021 13:40
@alamb alamb added ballista and removed ballista labels Jun 23, 2021
@alamb
Copy link
Contributor

alamb commented Jun 23, 2021

I think this is a nice change -- however, it seems to delete everything in dev -- and it appears there may be some stuff in there that is used but not part of CI (e.g. the ballista docker files that were changed in #597)

@andygrove @edrevo is there some place we can figure out what is used by Ballista?

@edrevo
Copy link
Contributor

edrevo commented Jun 23, 2021

everything under dev/docker and dev/integration-tests.sh.

@jimexist jimexist force-pushed the unvendor-archery branch 2 times, most recently from 6382b98 to f9fae20 Compare June 29, 2021 03:01
@jimexist
Copy link
Member Author

jimexist commented Jun 29, 2021

everything under dev/docker and dev/integration-tests.sh.

i have brought back these files

alamb
alamb approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change. Thank you @jimexist

@alamb alamb changed the title Unvendor archery Unvendor archery, clean up old files in dev Jun 29, 2021
@alamb
Copy link
Contributor

alamb commented Jun 29, 2021

My apologies to anyone for whom this messes up their workflow. Onward! 🚀

@alamb alamb merged commit c7c0968 into apache:master Jun 29, 2021
@jimexist jimexist deleted the unvendor-archery branch June 29, 2021 13:57
@yjshen
Copy link
Member

yjshen commented Jun 30, 2021

@jimexist dev/integration-tests.sh relies on ./dev/build-ballista-docker.sh and some other scripts transitively. They should be brought back. cc @alamb

@jimexist
Copy link
Member Author

jimexist commented Jun 30, 2021

@jimexist dev/integration-tests.sh relies on ./dev/build-ballista-docker.sh and some other scripts transitively. They should be brought back. cc @alamb

see what i can do with #648

@alamb alamb mentioned this pull request Jul 1, 2021
Merged
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
@viirya
refactor: Remove method get_global_jclass (apache#580)
9f44a74 
* refactor: Remove method get_global_jclass

The method uses unsafe code to cast a value to a static lifetime using
std::mem::transmute. But none of users of the method actually seems to
depend on this lifetime extention. So to me it seems better to just call
the underlying `find_class` method and delete the unsafe code.

* Apply suggestions from code review

Remove no longer needed comments.

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>

---------

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
@simicd
docs: Add ASF attribution (apache#580)
476ca22 
* Add ASF attribution and update docs README

* Fix formatting

* Fix unit test

* Undo changes in functions & tests and requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

development-process Related to development process of DataFusion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jimexist @codecov-commenter @alamb @edrevo @yjshen