Skip to content

Conversation

@jorgecarleitao
Copy link
Member

Closes #481

@jorgecarleitao jorgecarleitao requested review from kszucs and wesm June 21, 2021 21:27
@jorgecarleitao
Copy link
Member Author

Notice that I made it such that it uses the apache-rat instead of archery; this way we do not depend on archery for this.

I am not sure whether this is sufficient, though; I assume that archery just calls the apache-rat.

Regardless, imo this is better than what we have, where we currently do not even check for the headers of .rs files.

@jorgecarleitao
Copy link
Member Author

Build log on my repo after removing the license from arrow/src/compute/kernels/aggregate.rs, on top of this PR: https://github.com/jorgecarleitao/arrow-rs/runs/2879443315?check_suite_focus=true

Run ./dev/release/run-rat.sh .
NOT APPROVED: arrow/src/compute/kernels/aggregate.rs (./arrow/src/compute/kernels/aggregate.rs): false
1 unapproved licences. Check rat report: rat.txt
Error: Process completed with exit code 1.

@codecov-commenter
Copy link

Codecov Report

Merging #482 (b9ca4f5) into master (9f56afb) will decrease coverage by 0.00%.
The diff coverage is 98.70%.

❗ Current head b9ca4f5 differs from pull request most recent head 7a86ee0. Consider uploading reports for the commit 7a86ee0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   82.65%   82.65%   -0.01%     
==========================================
  Files         165      165              
  Lines       45556    45524      -32     
==========================================
- Hits        37655    37628      -27     
+ Misses       7901     7896       -5     
Impacted Files Coverage Δ
parquet/src/encodings/decoding.rs 92.47% <ø> (ø)
parquet/src/arrow/array_reader.rs 77.45% <57.14%> (+0.13%) ⬆️
arrow/src/json/reader.rs 84.02% <97.56%> (+0.11%) ⬆️
arrow/src/array/array_binary.rs 90.13% <100.00%> (ø)
arrow/src/array/array_boolean.rs 90.90% <100.00%> (ø)
arrow/src/array/array_dictionary.rs 84.56% <100.00%> (ø)
arrow/src/array/array_primitive.rs 94.70% <100.00%> (ø)
arrow/src/array/array_struct.rs 87.84% <100.00%> (-0.59%) ⬇️
arrow/src/array/array_union.rs 86.93% <100.00%> (ø)
arrow/src/array/builder.rs 85.78% <100.00%> (-0.13%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f56afb...7a86ee0. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @jorgecarleitao

@alamb alamb merged commit 4c7d418 into apache:master Jun 22, 2021
@alamb alamb mentioned this pull request Jun 22, 2021
@jorgecarleitao jorgecarleitao deleted the fix-rat branch June 22, 2021 10:42
@alamb alamb added the development-process Related to development process of arrow-rs label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release Audit Tool (RAT) is not being triggered

3 participants