Skip to content

Conversation

@yjshen
Copy link
Member

@yjshen yjshen commented Jun 22, 2021

Which issue does this PR close?

Closes #596.

Rationale for this change

partition_point is stabilized in 1.52.0, we should update the rust docker image used in the integration test to fix the broken test.

What changes are included in this PR?

Update rust docker image version

Are there any user-facing changes?

No.

@yjshen yjshen changed the title [hotfix]Use Rust nightly in docker for integration test [TEST]Use Rust nightly in docker for integration test Jun 22, 2021
@yjshen yjshen force-pushed the docker_rust_nightly branch from ecb44ba to 520645d Compare June 22, 2021 03:35
@houqp
Copy link
Member

houqp commented Jun 22, 2021

arrow shouldn't require nightly to build though, have you tried bumping rust version to the latest stable release?

@yjshen
Copy link
Member Author

yjshen commented Jun 22, 2021

@houqp Thanks for the guidance, I've updated the docker image version used in the integration test, PTAL.

@yjshen yjshen changed the title [TEST]Use Rust nightly in docker for integration test [TEST]Update Rust version to 1.53.0 for integration test Jun 22, 2021
Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using stable label is better

@alamb alamb added development-process Related to development process of DataFusion ballista labels Jun 23, 2021
@alamb
Copy link
Contributor

alamb commented Jun 23, 2021

FYI @andygrove and @edrevo

@alamb alamb merged commit 9cd58e4 into apache:master Jun 23, 2021
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
Closes apache#672 rustls
Closes #682 syn
Closes apache#653 parking_lot
closes apache#648 object_store
Closes apache#625 h2
Closes apache#623 tokio
Closes apache#608 mio
Closes apache#597 pyo3
Closes apache#642 pyo3-build-config
Closes apache#627 prost
Closes apache#634 prost-types
Closes apache#637 async-trait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration test build failure due to arrow-rs using unstable feature

4 participants