[WIP] Upgrade to arrow/parquet 57.0.0 #17888

alamb · 2025-10-02T14:40:31Z

Which issue does this PR close?

Related to Release arrow-rs / parquet Major version 57.0.0 (October 2025) arrow-rs#7835

TODO:

Fix enforce_sorting.rs tests

Rationale for this change

Upgrade to the latest arrow

Also, there are several new features in arrow-57 that I want to be able to test including Variant, arrow-avro, and a new metadata reader.

What changes are included in this PR?

Update arrow/parquet
Update prost
Update substrait
Update pbjson
Make API changes to avoid deprecated APIs

Are these changes tested?

By CI

Are there any user-facing changes?

New arrow

alamb · 2025-10-02T15:41:51Z

Many of the current failures are due because this used to work:

select arrow_cast('2021-01-01T00:00:00', 'Timestamp(Nanosecond, Some("-05:00"))'

or

SELECT arrow_cast(secs, 'Timestamp(Millisecond, None)') FROM t

After the arrow 57 upgrade it fails with errors like

statement error DataFusion error: Execution error: Unsupported type 'Timestamp\(Nanosecond, None\)'\. Must be a supported arrow type name such as 'Int32' or 'Timestamp\(ns\)'\. Error expected double quoted string for Timezone, got 'None'

# arrow_typeof_timestamp
query T
SELECT arrow_typeof(now()::timestamp)
----
Timestamp(ns)

I believe the problem is that the format of the timezone has changed into Timestamp(ns) and then the FromStr method doesn't handle that. I will work on filing an update

I think what we need to do is support both formats for backwards compatibility. I will work on an upstream issue

alamb · 2025-10-02T17:18:34Z

datafusion-examples/examples/flight/flight_client.rs


    // Create Flight client
-    let mut client = FlightServiceClient::connect("http://localhost:50051").await?;
+    let endpoint = Endpoint::new("http://localhost:50051")?;


This is due to new version of tonic

alamb · 2025-10-02T17:18:57Z

datafusion-examples/examples/flight/flight_server.rs


                // add an initial FlightData message that sends schema
                let options = arrow::ipc::writer::IpcWriteOptions::default();
+                let mut compression_context = CompressionContext::default();


Due to

Reuse zstd compression context when writing IPC arrow-rs#8405

alamb · 2025-10-02T17:19:23Z

datafusion/functions-aggregate-common/src/utils.rs


-            let validate =
-                T::validate_decimal_precision(new_value, self.target_precision);
+            let validate = T::validate_decimal_precision(


Due to this (get better messages)

[Decimal] Add scale argument to validation functions to ensure accurate error logging arrow-rs#8396

alamb · 2025-10-02T17:22:13Z

datafusion/sqllogictest/test_files/array.slt

-List(Field { name: "item", data_type: List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type: Float64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type: Float64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }), nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type: Float64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
+List(nullable List(nullable Int64)) List(nullable Float64) List(nullable Utf8)


Many of the diffs in this file are related to improvements in DataType display, tracked in this ticket

Improve Display for DataType arrow-rs#8351

I will try and call out individual changes when I see them. Lists are way nicer now:

Improve Display for DataType and Field arrow-rs#8290

alamb · 2025-10-02T17:22:38Z

datafusion/sqllogictest/test_files/array.slt

 05)--------ProjectionExec: expr=[]
 06)----------CoalesceBatchesExec: target_batch_size=8192
-07)------------FilterExec: substr(md5(CAST(value@0 AS Utf8View)), 1, 32) IN ([Literal { value: Utf8View("7f4b18de3cfeb9b4ac78c381ee2ad278"), field: Field { name: "lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} } }, Literal { value: Utf8View("a"), field: Field { name: "lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} } }, Literal { value: Utf8View("b"), field: Field { name: "lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} } }, Literal { value: Utf8View("c"), field: Field { name: "lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} } }])
+07)------------FilterExec: substr(md5(CAST(value@0 AS Utf8View)), 1, 32) IN ([Literal { value: Utf8View("7f4b18de3cfeb9b4ac78c381ee2ad278"), field: Field { name: "lit", data_type: Utf8View } }, Literal { value: Utf8View("a"), field: Field { name: "lit", data_type: Utf8View } }, Literal { value: Utf8View("b"), field: Field { name: "lit", data_type: Utf8View } }, Literal { value: Utf8View("c"), field: Field { name: "lit", data_type: Utf8View } }])


Due to

Improve Display for DataType and Field arrow-rs#8290

alamb · 2025-10-02T17:23:21Z

datafusion/sqllogictest/test_files/arrow_typeof.slt

 SELECT arrow_typeof(now()::timestamp)
 ----
-Timestamp(Nanosecond, None)
+Timestamp(ns)


Due to

Improve Display formatting of DataType::Timestamp arrow-rs#8425

alamb · 2025-10-02T17:23:41Z

datafusion/sqllogictest/test_files/arrow_typeof.slt


 ## Timestamps: Create a table

+statement ok


The timestamp format has changed (improved!) so let's also add tests for the new format

alamb · 2025-10-02T17:25:17Z

datafusion/substrait/Cargo.toml

 pbjson-types = { workspace = true }
 prost = { workspace = true }
-substrait = { version = "0.58", features = ["serde"] }
+substrait = { version = "0.59", features = ["serde"] }


since prost is updated, we also must update substrait

alamb · 2025-10-03T20:23:37Z

datafusion-cli/src/main.rs

-        | alltypes_plain.parquet            | 1851            | 10181               | 2    | page_index=false |
-        | alltypes_tiny_pages.parquet       | 454233          | 881418              | 2    | page_index=true  |
-        | lz4_raw_compressed_larger.parquet | 380836          | 2939                | 2    | page_index=false |
+        | alltypes_plain.parquet            | 1851            | 10309               | 2    | page_index=false |


I don't know why the metadata size has increased. I will investigate

alamb · 2025-10-03T20:24:04Z

datafusion/common/src/dfschema.rs

-        let expected = "Field { name: \"c0\", data_type: Boolean, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }, \
-        Field { name: \"c1\", data_type: Boolean, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }";
-        assert_eq!(expected, arrow_schema.to_string());
+        insta::assert_snapshot!(arrow_schema.to_string(), @r#"Field { "c0": nullable Boolean }, Field { "c1": nullable Boolean }"#);


many many diffs are due to the changes in formatting of Fields and DataTypes (see below)

alamb · 2025-10-03T20:24:26Z

datafusion/core/tests/dataframe/dataframe_functions.rs

+    +----------------------+
+    | arrow_typeof(test.l) |
+    +----------------------+
+    | List(nullable Int32) |


the new display is much easier to read in my opinion

alamb · 2025-10-03T21:02:38Z

Ok, the tests are now looking good enough to test with the new thrift decoder

alamb · 2025-10-04T10:03:17Z

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.14.0-1016-gcp #17~24.04.1-Ubuntu SMP Wed Sep 3 01:55:36 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/upgrade_arrow_57 (0cfb693) to 0f3cf27 diff using: tpch_mem
Results will be posted here when complete

alamb · 2025-10-04T10:35:09Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_upgrade_arrow_57
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ alamb_upgrade_arrow_57 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 172.82 ms │              170.20 ms │     no change │
│ QQuery 2     │  25.32 ms │               26.80 ms │  1.06x slower │
│ QQuery 3     │  40.67 ms │               35.01 ms │ +1.16x faster │
│ QQuery 4     │  28.11 ms │               27.70 ms │     no change │
│ QQuery 5     │  75.67 ms │               74.89 ms │     no change │
│ QQuery 6     │  19.71 ms │               19.40 ms │     no change │
│ QQuery 7     │ 211.76 ms │              211.24 ms │     no change │
│ QQuery 8     │  33.37 ms │               30.89 ms │ +1.08x faster │
│ QQuery 9     │ 102.87 ms │               93.38 ms │ +1.10x faster │
│ QQuery 10    │  58.60 ms │               57.87 ms │     no change │
│ QQuery 11    │  16.66 ms │               17.12 ms │     no change │
│ QQuery 12    │  51.03 ms │               50.17 ms │     no change │
│ QQuery 13    │  45.56 ms │               46.20 ms │     no change │
│ QQuery 14    │  13.72 ms │               13.95 ms │     no change │
│ QQuery 15    │  24.12 ms │               23.72 ms │     no change │
│ QQuery 16    │  24.35 ms │               24.28 ms │     no change │
│ QQuery 17    │ 147.33 ms │              145.37 ms │     no change │
│ QQuery 18    │ 316.29 ms │              315.38 ms │     no change │
│ QQuery 19    │  36.14 ms │               36.46 ms │     no change │
│ QQuery 20    │  47.59 ms │               48.14 ms │     no change │
│ QQuery 21    │ 327.74 ms │              294.32 ms │ +1.11x faster │
│ QQuery 22    │  20.95 ms │               19.61 ms │ +1.07x faster │
└──────────────┴───────────┴────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                     ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                     │ 1840.37ms │
│ Total Time (alamb_upgrade_arrow_57)   │ 1782.09ms │
│ Average Time (HEAD)                   │   83.65ms │
│ Average Time (alamb_upgrade_arrow_57) │   81.00ms │
│ Queries Faster                        │         5 │
│ Queries Slower                        │         1 │
│ Queries with No Change                │        16 │
│ Queries with Failure                  │         0 │
└───────────────────────────────────────┴───────────┘

alamb · 2025-10-04T10:35:11Z

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.14.0-1016-gcp #17~24.04.1-Ubuntu SMP Wed Sep 3 01:55:36 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/upgrade_arrow_57 (0cfb693) to 0f3cf27 diff using: clickbench_partitioned
Results will be posted here when complete

alamb · 2025-10-04T10:52:18Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_upgrade_arrow_57
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ alamb_upgrade_arrow_57 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.22 ms │                2.14 ms │     no change │
│ QQuery 1     │    49.54 ms │               49.79 ms │     no change │
│ QQuery 2     │   133.80 ms │              141.22 ms │  1.06x slower │
│ QQuery 3     │   154.13 ms │              158.96 ms │     no change │
│ QQuery 4     │   999.02 ms │             1029.05 ms │     no change │
│ QQuery 5     │  1457.78 ms │             1484.94 ms │     no change │
│ QQuery 6     │     2.10 ms │                2.23 ms │  1.06x slower │
│ QQuery 7     │    53.99 ms │               54.98 ms │     no change │
│ QQuery 8     │  1378.95 ms │             1413.04 ms │     no change │
│ QQuery 9     │  1743.92 ms │             1760.12 ms │     no change │
│ QQuery 10    │   378.81 ms │              391.56 ms │     no change │
│ QQuery 11    │   435.88 ms │              445.91 ms │     no change │
│ QQuery 12    │  1318.89 ms │             1368.96 ms │     no change │
│ QQuery 13    │  2094.11 ms │             2109.04 ms │     no change │
│ QQuery 14    │  1255.34 ms │             1275.76 ms │     no change │
│ QQuery 15    │  1162.03 ms │             1224.07 ms │  1.05x slower │
│ QQuery 16    │  2635.18 ms │             2656.01 ms │     no change │
│ QQuery 17    │  2586.47 ms │             2645.02 ms │     no change │
│ QQuery 18    │  5483.36 ms │             4868.30 ms │ +1.13x faster │
│ QQuery 19    │   124.80 ms │              126.32 ms │     no change │
│ QQuery 20    │  2104.33 ms │             1991.58 ms │ +1.06x faster │
│ QQuery 21    │  2473.34 ms │             2322.82 ms │ +1.06x faster │
│ QQuery 22    │  4514.85 ms │             3935.77 ms │ +1.15x faster │
│ QQuery 23    │ 14978.72 ms │            12767.28 ms │ +1.17x faster │
│ QQuery 24    │   214.97 ms │              214.15 ms │     no change │
│ QQuery 25    │   518.82 ms │              516.03 ms │     no change │
│ QQuery 26    │   223.15 ms │              214.72 ms │     no change │
│ QQuery 27    │  2948.86 ms │             2848.18 ms │     no change │
│ QQuery 28    │ 23563.88 ms │            24515.81 ms │     no change │
│ QQuery 29    │   986.38 ms │              966.06 ms │     no change │
│ QQuery 30    │  1301.06 ms │             1316.39 ms │     no change │
│ QQuery 31    │  1344.98 ms │             1342.06 ms │     no change │
│ QQuery 32    │  4990.45 ms │             4519.35 ms │ +1.10x faster │
│ QQuery 33    │  5926.40 ms │             5679.44 ms │     no change │
│ QQuery 34    │  5836.64 ms │             6371.95 ms │  1.09x slower │
│ QQuery 35    │  1978.57 ms │             1959.59 ms │     no change │
│ QQuery 36    │   124.02 ms │              120.34 ms │     no change │
│ QQuery 37    │    51.09 ms │               54.29 ms │  1.06x slower │
│ QQuery 38    │   120.80 ms │              121.73 ms │     no change │
│ QQuery 39    │   198.05 ms │              198.87 ms │     no change │
│ QQuery 40    │    43.84 ms │               43.57 ms │     no change │
│ QQuery 41    │    36.81 ms │               38.73 ms │  1.05x slower │
│ QQuery 42    │    31.34 ms │               31.72 ms │     no change │
└──────────────┴─────────────┴────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                     ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                     │ 97961.63ms │
│ Total Time (alamb_upgrade_arrow_57)   │ 95297.87ms │
│ Average Time (HEAD)                   │  2278.18ms │
│ Average Time (alamb_upgrade_arrow_57) │  2216.23ms │
│ Queries Faster                        │          6 │
│ Queries Slower                        │          6 │
│ Queries with No Change                │         31 │
│ Queries with Failure                  │          0 │
└───────────────────────────────────────┴────────────┘

alamb · 2025-10-04T10:52:21Z

🤖 ./gh_compare_branch.sh Benchmark Script Running
Linux aal-dev 6.14.0-1016-gcp #17~24.04.1-Ubuntu SMP Wed Sep 3 01:55:36 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/upgrade_arrow_57 (0cfb693) to 0f3cf27 diff using: clickbench_extended
Results will be posted here when complete

alamb · 2025-10-04T11:00:18Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_upgrade_arrow_57
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ alamb_upgrade_arrow_57 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │  2748.60 ms │             2599.96 ms │ +1.06x faster │
│ QQuery 1     │  1344.48 ms │             1212.98 ms │ +1.11x faster │
│ QQuery 2     │  2453.12 ms │             2329.05 ms │ +1.05x faster │
│ QQuery 3     │  1166.94 ms │             1181.82 ms │     no change │
│ QQuery 4     │  2255.61 ms │             2220.57 ms │     no change │
│ QQuery 5     │ 27120.42 ms │            27691.74 ms │     no change │
│ QQuery 6     │  4325.56 ms │             4126.85 ms │     no change │
│ QQuery 7     │  3581.20 ms │             3545.46 ms │     no change │
└──────────────┴─────────────┴────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                     ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                     │ 44995.92ms │
│ Total Time (alamb_upgrade_arrow_57)   │ 44908.43ms │
│ Average Time (HEAD)                   │  5624.49ms │
│ Average Time (alamb_upgrade_arrow_57) │  5613.55ms │
│ Queries Faster                        │          3 │
│ Queries Slower                        │          0 │
│ Queries with No Change                │          5 │
│ Queries with Failure                  │          0 │
└───────────────────────────────────────┴────────────┘

github-actions bot added the common Related to common crate label Oct 2, 2025

alamb mentioned this pull request Oct 2, 2025

Test thrift-remodel branch with DataFusion apache/arrow-rs#8513

Open

github-actions bot added substrait Changes to the substrait crate proto Related to proto crate labels Oct 2, 2025

alamb mentioned this pull request Oct 2, 2025

DataType parsing no longer works correctly for old formatted timestamps apache/arrow-rs#8539

Closed

alamb force-pushed the alamb/upgrade_arrow_57 branch from ed43cc0 to ee2de0c Compare October 2, 2025 17:16

github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Oct 2, 2025

alamb commented Oct 2, 2025

View reviewed changes

github-actions bot added the core Core DataFusion crate label Oct 2, 2025

alamb force-pushed the alamb/upgrade_arrow_57 branch from 9d06200 to 1b7b559 Compare October 2, 2025 18:56

github-actions bot added the logical-expr Logical plan and expressions label Oct 2, 2025

This was referenced Oct 3, 2025

Refactor: Update enforce_sorting tests to use insta snapshots for easier updates (part 1) #17900

Open

Refactor: Split test_window_partial_constant_and_set_monotonicity from enforce_sorting #17903

Open

alamb force-pushed the alamb/upgrade_arrow_57 branch from 8ecbbed to d3b328b Compare October 3, 2025 15:48

alamb mentioned this pull request Oct 3, 2025

chore(deps): bump substrait from 0.58.0 to 0.60.1 #17841

Closed

TEMP: pin to main of arrow-rs

abcf8db

alamb force-pushed the alamb/upgrade_arrow_57 branch from f61623e to 9f6a390 Compare October 3, 2025 16:04

alamb mentioned this pull request Oct 3, 2025

Complete phase 1 of the Thrift remodel for the parquet crate apache/arrow-rs#8530

Draft

github-actions bot added sql SQL Planner physical-expr Changes to the physical-expr crates optimizer Optimizer rules functions Changes to functions implementation physical-plan Changes to the physical-plan crate labels Oct 3, 2025

alamb force-pushed the alamb/upgrade_arrow_57 branch from d5bd26e to 7709acc Compare October 3, 2025 20:26

alamb commented Oct 3, 2025

View reviewed changes

alamb added 3 commits October 3, 2025 17:06

Update pin to latest arrow-rs

4432bae

taplo format

5e184ee

Update for new APIs, update other dependencies

5e1ea80

alamb force-pushed the alamb/upgrade_arrow_57 branch from 7709acc to 5e1ea80 Compare October 3, 2025 21:11

Null --> Float 16 cast works now

0cfb693

alamb mentioned this pull request Oct 4, 2025

[EPIC] Support VARIANT type for unstructured data #16116

Open

4 tasks

alamb mentioned this pull request Oct 4, 2025

[TESTING] Test thrift-remodel branch with datafusion #17916

Draft

[WIP] Upgrade to arrow/parquet 57.0.0 #17888

Are you sure you want to change the base?

[WIP] Upgrade to arrow/parquet 57.0.0 #17888

Conversation

alamb commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

TODO:

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

alamb commented Oct 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alamb commented Oct 3, 2025

Uh oh!

alamb commented Oct 4, 2025

Uh oh!

alamb commented Oct 4, 2025

Uh oh!

alamb commented Oct 4, 2025

Uh oh!

alamb commented Oct 4, 2025

Uh oh!

alamb commented Oct 4, 2025

Uh oh!

alamb commented Oct 4, 2025

Uh oh!

Uh oh!

alamb commented Oct 2, 2025 •

edited

Loading