Improve Display formatting of DataType::Timestamp #8425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
|
Looks like there are some tests to update on this one |
mbrobbel
approved these changes
Sep 24, 2025
This was referenced Oct 2, 2025
|
I hit an issue related to this PR when testing DataFusion with the new release |
alamb
added a commit
that referenced
this pull request
Oct 3, 2025
# Which issue does this PR close? - Closes #8539 # Rationale for this change Systems like DataFusion use the string representation of DataType in their public APIs but the type names have changed after - #8425 We should retain backwards compatibility with the old type names too # What changes are included in this PR? 1. Support old style `Timestamp(Nanosecond, None)` and `Timestamp(Nanosecond, None)` style timestamp specifiers # Are these changes tested? Yes, with new tests # Are there any user-facing changes? See above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DisplayforDataType#8351Rationale for this change
DataType:s end up in a lot of error messages, and we want them easy and readable, without and Rust-stuff in them like
SomeandNoneWhat changes are included in this PR?
Before:
After
Are these changes tested?
Yes
Are there any user-facing changes?
Yes, this is a breaking change