Skip to content

[TESTING] Test thrift-remodel branch with datafusion #17916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[TESTING] Test thrift-remodel branch with datafusion #17916

wants to merge 8 commits into from
+760 −814

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 4, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

This PR is not meant to be merged -- I am using it to test the proposed
thrift-remodel branch with DataFusion. The thrift-remodel branch has
a brand new, much faster, thrift metadata decoder.

Specifically, this PR is to run the DataFusion test suite with the thrift-remodel branch
of arrow-rs to see if there are any issues before we merge it.

What changes are included in this PR?

Are these changes tested?

Changes

Things that would help upgrade

  1. Add PrimitiveColumnIndex::len() (can fake with min_values.len())

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate common Related to common crate proto Related to proto crate functions Changes to functions implementation physical-plan Changes to the physical-plan crate labels Oct 4, 2025
@github-actions github-actions bot added the datasource Changes to the datasource crate label Oct 4, 2025
@alamb alamb mentioned this pull request Oct 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alamb