WIP: Update to sqlparser-rs 0.52.0 pre-release #13282
Draft
+43
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
commented
Nov 6, 2024
| @@ -153,7 +153,7 @@ b 1 29 -18218 994303988 5983957848665088916 204 9489 3275293996 1485709125918647 | |||
| c 2 1 18109 2033001162 -6513304855495910254 25 43062 1491205016 5863949479783605708 0.110830784 0.929409733247 6WfVFBVGJSQb7FhA7E0lBwdvjfZnSW | |||
|
|
|||
| # can't distinct on * | |||
| query error DataFusion error: SQL error: ParserError\("Expected: an expression:, found: \*"\) | |||
| query error DataFusion error: SQL error: ParserError\("Expected: an expression, found: \*"\) | |||
There was a problem hiding this comment.
error messages improved wiht apache/datafusion-sqlparser-rs#1434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Related to apache/datafusion-sqlparser-rs#1423
I am testing out the upgrade to make sure we haven't broken something seriously
What changes are included in this PR?
This PR pins DataFusion to the code in :
0.52.0release, add scripts/ instructions for ASF releases datafusion-sqlparser-rs#1479Makes API changes
Are these changes tested?
By CI
Are there any user-facing changes?