Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant punctuation #1434

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

Fischer0522
Copy link
Contributor

related to #1433

@git-hulk
Copy link
Member

git-hulk commented Sep 19, 2024

@Fischer0522 Need to fix test cases as well. You can run cargo test --all-features on your side to check this.

@Fischer0522
Copy link
Contributor Author

@Fischer0522 Need to fix test cases as well. You can run cargo test --all-features on your side to check this.

done.

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @iffyio

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fischer0522 and @git-hulk

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10936890491

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.336%

Totals Coverage Status
Change from base Build 10892026190: 0.0%
Covered Lines: 29446
Relevant Lines: 32961

💛 - Coveralls

@Fischer0522
Copy link
Contributor Author

Can this pr be merged before next release? we are using sqlparser-rs in our project and this issue makes my leader mildly irritated @alamb

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb alamb merged commit 71318df into apache:main Sep 20, 2024
10 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 20, 2024

Can this pr be merged before next release? we are using sqlparser-rs in our project and this issue makes my leader mildly irritated @alamb

Of course! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants