[WIP] 8.2.0 proposal WIP for discussion#712
Closed
brody4hire wants to merge 31 commits intoapache:8.1.xfrom
Closed
[WIP] 8.2.0 proposal WIP for discussion#712brody4hire wants to merge 31 commits intoapache:8.1.xfrom
brody4hire wants to merge 31 commits intoapache:8.1.xfrom
Conversation
There may very well be more of these. (Keep tizen & wp8 fixtures still needed in minor release)
The checking for these warning messages is already done in util.spec.js.
(no change to .eslintignore for minor release)
Tests 012 and 014 were both seemingly trying to test the same thing and both failing to do so. I replaced them with a fixed Test 012.
This reverts commit c50ec20. XXX XXX
This changes the test subject in restore.spec from `cordova/prepare` to `cordova/restore-util`. In doing so we can relatively easily stub out the actual platform/plugin installation that made these tests so unreliable but that we actually barely tested.
- Fix comments and test names - Simplify package.json restoration test - Use arrow functions - Use default timeout
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com> Co-authored-by: Darryl Pogue <darryl@dpogue.ca>
The shelljs usage in the cordova/serve spec is just commented out, since it has been disabled for some time and is due to be replaced anyway.
Author
|
The changes to move to fs-extra, which I just pushed after pushing the other commits, seem to mostly succeed on Node.js 4 but fail with a few errors. I will need some time to investigate this one, really hope I can solve it for the minor release. (Note that |
Member
|
Now that cordova-lib 9 is released, are we still realistically considering an 8.2.0 release? |
Author
|
Nope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started working on a proposal to make an 8.2.0 minor release with some changes from the master branch. Purpose is to get some of the changes into users' hands asap, especially some more of the cleanup, deprecation message from GH-707, and eventually migration to fs-extra. This proposed 8.2.0 minor release is meant to come after the patch release to fix dependencies.
This WIP PR is FYI only, I will raise another PR to actually make the 8.2.0 minor release assuming that we actually decide to proceed with it. Some commits are marked "XXX" to mean that they will need rewording, better explanation, or to be moved at some point. Also some GH numbers are deliberately not marked right in order to avoid extra noise in the related GH issues and PRs.
I am specifically reaching out to @raphinesse since he expressed interest in a minor release with the deprecation message.