Remove all usage of Q-specific methods on Promise instances#651
Merged
dpogue merged 4 commits intoapache:masterfrom Aug 26, 2018
Merged
Remove all usage of Q-specific methods on Promise instances#651dpogue merged 4 commits intoapache:masterfrom
dpogue merged 4 commits intoapache:masterfrom
Conversation
The checking for these warning messages is already done in util.spec.js.
Contributor
Author
|
Actually, the remove all part of this PR is only true with the changes from #650 which was originally part of this branch. Should we merge this now anyway? |
brody4hire
pushed a commit
to brody4hire/cordova-lib
that referenced
this pull request
Sep 30, 2018
brody4hire
pushed a commit
to brody4hire/cordova-lib
that referenced
this pull request
Sep 30, 2018
brody4hire
pushed a commit
to brody4hire/cordova-lib
that referenced
this pull request
Sep 30, 2018
The checking for these warning messages is already done in util.spec.js.
brody4hire
pushed a commit
to brody4hire/cordova-lib
that referenced
this pull request
Sep 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change landed, it should be safe to return native Promise instances from any modules consumed by
cordova-lib.