Skip to content

Linting improvements#669

Merged
raphinesse merged 5 commits intoapache:masterfrom
raphinesse:linting-improvements
Aug 28, 2018
Merged

Linting improvements#669
raphinesse merged 5 commits intoapache:masterfrom
raphinesse:linting-improvements

Conversation

@raphinesse
Copy link
Contributor

Really just no-brainers here. I'm going to merge as soon as CI tests pass

Resolves #649 (partly)

@codecov-io
Copy link

Codecov Report

Merging #669 into master will not change coverage.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          57       57           
  Lines        3015     3015           
=======================================
  Hits         2436     2436           
  Misses        579      579
Impacted Files Coverage Δ
cordova-lib.js 50% <ø> (ø) ⬆️
src/hooks/HooksRunner.js 84.34% <100%> (ø) ⬆️
src/cordova/plugin/plugin_spec_parser.js 100% <100%> (ø) ⬆️
src/platforms/platforms.js 100% <100%> (ø) ⬆️
src/plugman/util/dependencies.js 93.18% <100%> (ø) ⬆️
src/plugman/install.js 90.07% <100%> (ø) ⬆️
src/plugman/uninstall.js 90.85% <100%> (ø) ⬆️
src/plugman/util/strip-license.js 100% <100%> (ø) ⬆️
src/cordova/restore-util.js 94.33% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3994b10...27854f3. Read the comment docs.

@raphinesse raphinesse merged commit 39abbe0 into apache:master Aug 28, 2018
@raphinesse raphinesse deleted the linting-improvements branch August 28, 2018 13:13
brody4hire pushed a commit to brody4hire/cordova-lib that referenced this pull request Sep 30, 2018
(no change to .eslintignore for minor release)
brody4hire pushed a commit to brody4hire/cordova-lib that referenced this pull request Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants