Repository navigation
Conversation
Contributor
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use backing maps for ordinary unknown-column collector keys to avoid repeated reflective lookup and string interning during Storage Write API conversion.
Why
Unknown-column capture, nested collector attachment, and empty-STRUCT pruning currently use
TableRowmap operations. Those operations consultGenericDatamodel metadata and intern field names, even for ordinary keys. With automatic schema updates, collector bookkeeping also runs for known nested fields, so deeply repeated records pay this cost even without unknown columns.This patch uses the existing backing map for ordinary keys while retaining
TableRowcollectors and their allocation behavior. Annotated model fields still use the original setter and map operations. The emptiness shortcut treats every non-nullfvalue as an entry, including an empty cell list, and falls back to the original behavior if future model fields appear.Context
Closes #40492.
Related to #40203 (descriptor lookup) and #40204 (required-field validation), but independent of both. This patch changes collector access only; it does not change descriptor lookup, message validation, timestamp conversion, or public converter signatures.
What changed
Validation
protoc-gen-grpc-javaexecutable is x86-only on macOS ARM. The isolated build does not replace a full master build or upstream CI.