Repository navigation
Conversation
Contributor
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Member
|
R: @ahmedabu98 Sorry to send so many to you, but am I right that you are the current expert in the storage write API paths? |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40189
When
allowMissingRequiredFieldsis true, conversion already skips the missing-required check, but both build sites still callbuild(), which re-validates the whole tree and can throw. This makes the flag consistent at build time:falsepath unchanged; a nested test pins the exactSchemaMissingRequiredFieldExceptiondiagnostic.truealready use all-optional descriptors: identical output, one redundantisInitialized()walk removed.CHANGES.md: an external caller passingtruewith a strict descriptor now gets a partial message instead ofUninitializedMessageException. A one-time descriptor check can be added if preferred.Descriptor.findFieldByNamelookups in BigQuery Storage Write API TableRow conversion #40188.Tests: on/off parity for all-optional descriptors including unknown fields, strict-path failure unchanged, nested diagnostic chain, partial messages for map and positional rows. GCP IO suite green on JDK 11 and 17.
Related: #40188 (independent; either order).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.