Skip to content

[Java][BigQueryIO] Use schema ordinals as verified hints for TableRow descriptor lookup - #40203

Open
khaledh wants to merge 2 commits into
apache:masterfrom
khaledh:perf/table-row-field-descriptor-index
Open

khaledh wants to merge 2 commits into
apache:masterfrom
khaledh:perf/table-row-field-descriptor-index

Conversation

@khaledh

@khaledh khaledh commented Sep 21, 2026

Copy link
Copy Markdown

fixes #40188

messageFromMap resolves every field with Descriptor.findFieldByName, which concatenates and hashes the fully qualified name on each call. This records each field's ordinal in SchemaInformation and uses it as a lookup hint, verified by name, with findFieldByName as the fallback.

  • No cache, no shared state, no public API change.
  • Required-field validation and diagnostics unchanged.
  • JMH: 1.575 → 1.084 ms/op (−31%). Dataflow, production workload: −15.7% CPU/record with this change alone.

Tests: reordered descriptor (exact bytes), ordinal beyond descriptor length (fallback), required-field validation, concurrent conversion. GCP IO suite green on JDK 11 and 17.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @chamikaramj

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions

Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @Abacn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Avoid per-field Descriptor.findFieldByName lookups in BigQuery Storage Write API TableRow conversion

1 participant