Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jan 15, 2025

Rationale for this change

The pr aims to correct an error in doc Columnar.rst
It is following up #45265.

What changes are included in this PR?

Obviously, the following description does not match the example above.
image

Are these changes tested?

No, only for docs.

Are there any user-facing changes?

Reduce misunderstandings among end users.

@panbingkun
Copy link
Contributor Author

cc @mapleFU

@panbingkun
Copy link
Contributor Author

#45265 (comment)
image


**Example Layout: ``Struct<VarBinary, Int32>``**

The layout for ``[{'joe', 1}, {null, 2}, null, {'mark', 4}]``, having
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind change the string to

``[{'joe', 1}, {'alice', 2}, null, {'mark', 4}]`

? Seems changing this also makes the result works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me investigate carefully first. I will set this as draft first.
Once I have thought it through, I will ping you.
Thank you very much!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there seems to be no problem with this example, as seen from the following chapter Struct Validity
image

So, I will close it.
cc @mapleFU

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 15, 2025
@panbingkun panbingkun marked this pull request as draft January 15, 2025 09:25
@panbingkun panbingkun closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants