Skip to content

Conversation

@panbingkun
Copy link
Contributor

Rationale for this change

The pr aims to correct an error in doc Columnar.rst

What changes are included in this PR?

Obviously, the value of Length below is incorrect, it should be 5.
image

Are these changes tested?

No, only for docs.

Are there any user-facing changes?

Reduce misunderstandings among end users.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 15, 2025
@mapleFU mapleFU changed the title MINOR: [DOCS] Correct doc Columnar.rst MINOR: [DOCS] Correct ListView example doc in Columnar.rst Jan 15, 2025
@mapleFU mapleFU changed the title MINOR: [DOCS] Correct ListView example doc in Columnar.rst MINOR: [Docs] Correct ListView example doc in Columnar.rst Jan 15, 2025
@mapleFU mapleFU merged commit 3b932bb into apache:main Jan 15, 2025
9 checks passed
@mapleFU mapleFU removed the awaiting committer review Awaiting committer review label Jan 15, 2025
@mapleFU
Copy link
Member

mapleFU commented Jan 15, 2025

Thanks @panbingkun !

@panbingkun
Copy link
Contributor Author

Oh, bad, I have discovered another mistake in same doc.
I am preparing to update it, but it has already been merged in.
Let me update it with FOLLOWUP.
I'm very sorry, I'm currently reading this document and have just discovered the error below.

@mapleFU
Copy link
Member

mapleFU commented Jan 15, 2025

My bad! Feel free to add a new one

@panbingkun
Copy link
Contributor Author

Thanks @panbingkun !

Thanks for reviewing it. ❤️

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3b932bb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants