Skip to content

MINOR: [Docs][FOLLOWUP] Correct ListView example doc in Columnar.rst #45267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MINOR: [Docs][FOLLOWUP] Correct ListView example doc in Columnar.rst #45267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/source/format/Columnar.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ type.
**Example Layout: ``Struct<VarBinary, Int32>``**

The layout for ``[{'joe', 1}, {null, 2}, null, {'mark', 4}]``, having
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind change the string to

``[{'joe', 1}, {'alice', 2}, null, {'mark', 4}]`

? Seems changing this also makes the result works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me investigate carefully first. I will set this as draft first.
Once I have thought it through, I will ping you.
Thank you very much!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there seems to be no problem with this example, as seen from the following chapter Struct Validity
image

So, I will close it.
cc @mapleFU

child arrays ``['joe', null, 'alice', 'mark']`` and ``[1, 2, null, 4]``
child arrays ``['joe', null, null, 'mark']`` and ``[1, 2, null, 4]``
would be: ::

* Length: 4, Null count: 1
Expand All @@ -802,24 +802,24 @@ would be: ::

* Children arrays:
* field-0 array (`VarBinary`):
* Length: 4, Null count: 1
* Length: 4, Null count: 2
* Validity bitmap buffer:

| Byte 0 (validity bitmap) | Bytes 1-63 |
|--------------------------|-----------------------|
| 00001101 | 0 (padding) |
| 00001001 | 0 (padding) |

* Offsets buffer:

| Bytes 0-19 | Bytes 20-63 |
|----------------|-----------------------|
| 0, 3, 3, 8, 12 | unspecified (padding) |
| 0, 3, 3, 3, 7 | unspecified (padding) |

* Value buffer:

| Bytes 0-11 | Bytes 12-63 |
|----------------|-----------------------|
| joealicemark | unspecified (padding) |
| joemark | unspecified (padding) |

* field-1 array (int32 array):
* Length: 4, Null count: 1
Expand Down
Loading