Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Aug 6, 2024

Rationale for this change

This is a follow-on to #43566 which was merged earlier today. See #43570 for more detail on the entire set of changes.

What changes are included in this PR?

  • Replace instances where we call or document calling docker-compose with docker compose.

Are these changes tested?

Yes.

Are there any user-facing changes?

This PR includes the require user-facing changes to document things.

@github-actions github-actions bot added the awaiting review Awaiting review label Aug 6, 2024
@github-actions
Copy link

github-actions bot commented Aug 6, 2024

⚠️ GitHub issue #43570 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member

pitrou commented Aug 8, 2024

Note that more Archery changes were done in PR #43586.

@pitrou
Copy link
Member

pitrou commented Nov 13, 2024

@amoeba Do you want to revive this PR?

@amoeba
Copy link
Member Author

amoeba commented Nov 13, 2024

Yeah. Let me see what's needed to close this out now.

@amoeba
Copy link
Member Author

amoeba commented Nov 14, 2024

I rebased and went through the repo again to find any instances that needed attention. Waiting for CI but I think this is ready for a review.

@amoeba
Copy link
Member Author

amoeba commented Nov 14, 2024

Pushed one commit to fix the archery tests.

@amoeba amoeba marked this pull request as ready for review November 14, 2024 01:34
@amoeba
Copy link
Member Author

amoeba commented Nov 14, 2024

The three CI failures don't look related to me.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Nov 14, 2024
@amoeba
Copy link
Member Author

amoeba commented Nov 14, 2024

@kou 's suggestion encouraged me to do a more serious pass, trying to use "Docker Compose" everywhere I saw we were referring to the product/software rather than a shell command. See 71a365a. Some calls were subjective, though I think the most important thing has been done here (change docker-compose to docker compose for all example shell commands).

@pitrou do you want to take a last look here?

@amoeba amoeba requested review from kou and pitrou November 14, 2024 19:40
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd wait for @kou 's approval

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 736d706 into apache:main Nov 15, 2024
45 checks passed
@kou kou removed the awaiting merge Awaiting merge label Nov 15, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 15, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 736d706.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@amoeba
Copy link
Member Author

amoeba commented Nov 15, 2024

Thanks for the reminder @pitrou and for the reviews, both you and @kou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants