GH-43608: [CI][Archery] Prefer docker compose over docker-compose
#43586
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
pitrou
force-pushed
the
minor-docker-compose
branch
from
54e70a6 to
fc2f4bb
Compare
|
@github-actions crossbow submit wheel3.8* cuda |
|
pitrou
force-pushed
the
minor-docker-compose
branch
from
fc2f4bb to
53ced2e
Compare
|
@github-actions crossbow submit wheelcp38* cuda |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
minor-docker-compose
branch
from
53ced2e to
c9584b9
Compare
|
@github-actions crossbow submit wheelcp38* test-cuda* |
This comment was marked as outdated.
This comment was marked as outdated.
pitrou
force-pushed
the
minor-docker-compose
branch
from
c9584b9 to
600642d
Compare
|
@github-actions crossbow submit wheelcp38* test-cuda* jars skyhook arm |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit skyhook wheel-windows* |
This comment was marked as outdated.
This comment was marked as outdated.
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
This draft PR disables
ARCHERY_USE_DOCKER_CLIin a lot of places
I'm OK with this for now. We can enables it by follow-up tasks.
but we might actually want to keep wherever possible if it improves build caching (I have no idea).
I think that we need to use docker compose instead of docker-compose in all places eventually whether it improves build caching or not. Because docker-compose is obsolete.
github-actions
bot
added
awaiting changes
pitrou
force-pushed
the
minor-docker-compose
branch
from
60bcc37 to
ad96a65
Compare
github-actions
bot
added
awaiting change review
|
@github-actions crossbow submit skyhook cuda wheel-windows* jars arm64 |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit test-cuda* |
|
Revision: 84fee26f736646b68373324f7f50d9d52298c9ea Submitted crossbow builds: ursacomputing/crossbow @ actions-362b27ff33
|
|
@kou How about we deprecate ARCHERY_USE_DOCKER_CLI in another issue/PR? This doesn't seem necessary right now. |
|
@github-actions crossbow submit -g nightly-tests |
|
@github-actions crossbow submit -g nightly-packaging |
|
Revision: 2ac225a Submitted crossbow builds: ursacomputing/crossbow @ actions-bd221565a1
|
|
Revision: 2ac225a Submitted crossbow builds: ursacomputing/crossbow @ actions-2515f0589f
|
|
@github-actions crossbow submit hdfs |
|
Revision: 02cdd0a Submitted crossbow builds: ursacomputing/crossbow @ actions-e169e51a80
|
pitrou
changed the title
docker compose instead of docker-composedocker compose over docker-compose
|
|
|
The remaining CI failures look unrelated to these changes. |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
How about we deprecate ARCHERY_USE_DOCKER_CLI in another issue/PR?
I'm OK with this approach.
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e54ad41. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
On the Cuda self-hosted runners, we need to use legacy `docker-compose` on all Archery Docker invocations, including the "image push" step. This is because the Docker client version on those runners is too old to accept the `--file` option to the `compose` subcommand. This is a followup to #43586 . The image push step cannot easily be verified in a PR, hence this second PR. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
On the Cuda self-hosted runners, we need to use legacy `docker-compose` on all Archery Docker invocations, including the "image push" step. This is because the Docker client version on those runners is too old to accept the `--file` option to the `compose` subcommand. This is a followup to apache/arrow#43586 . The image push step cannot easily be verified in a PR, hence this second PR. Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2 participants
Rationale for this change
The
docker-composeutility is legacy, while the Docker CLI client now includes acomposesubcommand that attempts to be compatible with docker-compose YAML files.What changes are included in this PR?
docker composeby default whenarchery dockeris invoked, notdocker-composedocker-compose, in case of Docker CLI client is too old and doesn't support some options (such as--file).Are these changes tested?
Yes, on CI.
Are there any user-facing changes?
No.
docker compose, notdocker-compose#43608