Skip to content

Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator#62147

Merged
o-nikolas merged 9 commits intoapache:mainfrom
Shnekit:smus_notebook_operator
Feb 19, 2026
Merged

Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator#62147
o-nikolas merged 9 commits intoapache:mainfrom
Shnekit:smus_notebook_operator

Conversation

@Shnekit
Copy link
Contributor

@Shnekit Shnekit commented Feb 18, 2026

This PR picks up the work from #61498 (by @ruijiang-rjian, who is currently OOO) and adds the following on top:

Changes from original PR (#61498)

  • Added domain_id, project_id, and domain_region as optional parameters to SageMakerNotebookHook and SageMakerNotebookOperator

Added in this PR

  • Unit tests covering the new parameters in both the hook and operator
  • Fixed ruff-format failure: missing trailing comma in operator docstring example
  • Fixed update-spelling-wordlist-to-be-sorted failure: moved xlarge to correct sort position in docs/spelling_wordlist.txt

Closes #61498 once merged.

@Shnekit Shnekit requested a review from o-nikolas as a code owner February 18, 2026 21:51
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 18, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Feb 18, 2026
@o-nikolas o-nikolas merged commit 446b6ae into apache:main Feb 19, 2026
90 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 19, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
…new parameters to SageMakerNotebookOperator (apache#62147)

* add SageMaker Unified Studio domain_id, project_id, domain region as new parameters to SageMakerNotebookOperator

* Update sagemaker-studio version requirement

* Add unit tests for domain_id, project_id, domain_region params and fix static check failures
---------

Co-authored-by: Rui Jiang <rjian@amazon.com>
Co-authored-by: Rui Jiang <84741048+ruijiang-rjian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants