add SageMaker Unified Studio domain_id, project_id, domain region as new parameters to SageMakerNotebookOperator#61498
Closed
ruijiang-rjian wants to merge 5 commits intoapache:mainfrom
Closed
Conversation
…new parameters to SageMakerNotebookOperator
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
vincbeck
reviewed
Feb 5, 2026
providers/amazon/tests/unit/amazon/aws/hooks/test_sagemaker_unified_studio.py
Show resolved
Hide resolved
qashikin
approved these changes
Feb 5, 2026
vincbeck
approved these changes
Feb 5, 2026
o-nikolas
reviewed
Feb 6, 2026
|
|
||
| :param execution_name: The name of the notebook job to be executed, this is same as task_id. | ||
| :param domain_id: The domain ID for Amazon SageMaker Unified Studio. Optional - if not provided, | ||
| the SDK will attempt to resolve it from the MWAA environment. |
Contributor
There was a problem hiding this comment.
It is technically possible to export the right variables in a non-MWAA env, no?
Suggested change
| the SDK will attempt to resolve it from the MWAA environment. | |
| the SDK will attempt to resolve it from the environment. |
Same suggestion for below and in the operator module.
Contributor
|
Since this PR adds new functionality it requires also adding tests to cover the new functionality |
Contributor
|
Taken over by #62147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.