Skip to content

Conversation

@Ayush-srivastava504
Copy link
Contributor

Fixes: #58272

The docstring for GKEStartPodOperator stated the default value for on_finish_action as keep_pod.
Updated it to delete_pod to match the current behavior.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 23, 2026
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 23, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@shahar1
Copy link
Contributor

shahar1 commented Jan 24, 2026

Please refrain from making additional changes to this PR so I could see that the CI passes succesfully and merge. Thank you! :)

@Ayush-srivastava504
Copy link
Contributor Author

Sure sir, I won’t make any more changes. Thank you!

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small linting fix, I will apply the fix.

@Ayush-srivastava504
Copy link
Contributor Author

Thanks sir ,
appreciate it a lot!

@shahar1 shahar1 merged commit 5c53a1e into apache:main Jan 24, 2026
89 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 24, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Cloud Provider: Divergency in GKEStartPodOperator Docstring - on_finish_action dafault value

2 participants