-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix GKEStartPodOperator docstring default for on_finish_action #60960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GKEStartPodOperator docstring default for on_finish_action #60960
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
|
Please refrain from making additional changes to this PR so I could see that the CI passes succesfully and merge. Thank you! :) |
|
Sure sir, I won’t make any more changes. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small linting fix, I will apply the fix.
providers/google/src/airflow/providers/google/cloud/operators/kubernetes_engine.py
Outdated
Show resolved
Hide resolved
…kubernetes_engine.py
|
Thanks sir , |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Fixes: #58272
The docstring for GKEStartPodOperator stated the default value for on_finish_action as keep_pod.
Updated it to delete_pod to match the current behavior.
Was generative AI tooling used to co-author this PR?