-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add 31 missing airflowctl integration test commands #58701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 31 missing airflowctl integration test commands #58701
Conversation
|
Closed and open to trigger full test to run airflowctl integration tests |
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the PR. Let's see the CI before merge. Have you run the test with breeze locally?
|
Good call, I took another look with testing with breeze locally and it seems a lot of them were false positives. The test only checks for specific error strings, so many of the pre-existing tests were found to be using the wrong flags and were silently failing. New commit fixed the wrong CLI flags and positional args, some syntax bugs and ended up disabling a connection test that requires server configs. Current state now passes correctly. A needed followup is to improve the |
59276dd to
9374383
Compare
bugraoz93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Steve! Looks great!
|
Yes, a hook will make things more complete and in syntax. Exactly we are checking specific errors that states when API returns error which checks if we are doing wrong calls on integration level with endpoints whcih all aising the same error. Additionally we are checking if command is wrong is a way that not with the correct parameters means help text apperas to warn. Maybe we need to add one or more case for false positives |
9374383 to
f7a9d7a
Compare
* Add 31 missing airflowctl integration test commands * fix integration test parameters
* Add 31 missing airflowctl integration test commands * fix integration test parameters
* Add 31 missing airflowctl integration test commands * fix integration test parameters
Problem
Adds integration tests for airflowctl CLI commands. Currently, only 16 of 48 commands are tested.
Solution
Added 31 new command tests (now 47 total):
list,lint)get,update,test,import,deletex2)get,pause,unpause,update)get,delete)get,update,import,export,deletex2)get,update,import,export,deletex3)Added 3 JSON fixture files for import command testing (connections, pools, variables).
Commands not included
backfill get/pause/unpauseandassets get-queued-eventsneed IDs from prior create operationsdags deleteRelated Issues