Fix connection retrieval from secrets backend without conn_type #58528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
Author
|
Issue for further steps: #58529 |
Contributor
Author
|
Since the reporter is happy, @potiuk can I get a binding review? |
potiuk
approved these changes
Nov 24, 2025
potiuk
added
the
backport-to-v3-1-test
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 25, 2025
…n_type (apache#58528) (cherry picked from commit 762423c) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
ashb
pushed a commit
that referenced
this pull request
Nov 25, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #58313
Restore backward compatibility for connections stored in secrets backends that don't include the conn_type field. In Airflow 2, connections without
conn_typeworked correctly (with conn_type=None), but recently we introduceda validation check that required conn_type, breaking existing secrets backend configurations.
This change removes the ValueError check in Connection.from_json() that was preventing connections without conn_type from being deserialized, allowing them to work as they did in Airflow 2.
P.S: I do not know why I even added that check in the first place tbh.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.