Skip to content

[v3-1-test] Fix connection retrieval from secrets backend without conn_type (#58528) #58664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashb merged 1 commit into from
Nov 25, 2025
Merged

[v3-1-test] Fix connection retrieval from secrets backend without conn_type (#58528) #58664

ashb merged 1 commit into from
Nov 25, 2025

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 25, 2025

(cherry picked from commit 762423c)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

@amoghrajesh
[v3-1-test] Fix connection retrieval from secrets backend without con…
b096851 
…n_type (#58528)

(cherry picked from commit 762423c)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Merged
@amoghrajesh amoghrajesh marked this pull request as ready for review November 25, 2025 07:25
@ashb ashb merged commit 24d1594 into v3-1-test Nov 25, 2025
58 checks passed
@ashb ashb deleted the backport-762423c-v3-1-test branch November 25, 2025 08:17
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 1, 2025
@ephraimbuddy ephraimbuddy added this to the Airflow 3.1.4 milestone Dec 2, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
@github-actions @ephraimbuddy
[v3-1-test] Fix connection retrieval from secrets backend without con…
2fdda2d 
…n_type (#58528) (#58664)
@ephraimbuddy ephraimbuddy mentioned this pull request Dec 4, 2025
Closed
78 tasks
@jroachgolf84
Copy link
Collaborator

jroachgolf84 commented Dec 19, 2025

@amoghrajesh, I've chatted with a user testing 3.1.5 and they aren't able to retrieve connections without a conn_type, even after these changes (they're using AWS Secrets Manager). Do we need to update the Task SDK model to be something like conn_type: str | None = None? Right now it's still conn_type: str.

@jroachgolf84
Copy link
Collaborator

jroachgolf84 commented Dec 19, 2025

cc: @joshc3453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoghrajesh amoghrajesh amoghrajesh approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

Assignees

No one assigned

Labels

area:task-sdk type:bug-fix Changelog: Bug Fixes

Projects

None yet

Milestone

Airflow 3.1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jroachgolf84 @amoghrajesh @ashb @ephraimbuddy