Skip to content

Fix connection retrieval from secrets backend without conn_type #58528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 2 commits into from
Nov 25, 2025
Merged

Fix connection retrieval from secrets backend without conn_type #58528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ed354
Fix connection retrieval from secrets backend without conn_type
amoghrajesh Nov 20, 2025
3467f85
Merge branch 'main' into remove-conn-type-check
amoghrajesh Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions task-sdk/src/airflow/sdk/definitions/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,12 +293,6 @@ def to_dict(self, *, prune_empty: bool = False, validate: bool = True) -> dict[s
@classmethod
def from_json(cls, value, conn_id=None) -> Connection:
kwargs = json.loads(value)
conn_type = kwargs.get("conn_type", None)
if not conn_type:
raise ValueError(
"Connection type (conn_type) is required but missing from connection configuration. "
"Please add 'conn_type' field to your connection definition."
)
extra = kwargs.pop("extra", None)
if extra:
kwargs["extra"] = extra if isinstance(extra, str) else json.dumps(extra)
Expand Down
17 changes: 0 additions & 17 deletions task-sdk/tests/task_sdk/definitions/test_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,23 +190,6 @@ def test_from_json(self):
assert connection.host == "localhost"
assert connection.port == 5432

def test_from_json_missing_conn_type(self):
"""Test that missing conn_type throws an error while using from_json."""
import re

json_data = {
"host": "localhost",
"port": "5432",
}

with pytest.raises(
ValueError,
match=re.escape(
"Connection type (conn_type) is required but missing from connection configuration. Please add 'conn_type' field to your connection definition."
),
):
Connection.from_json(json.dumps(json_data), conn_id="test_conn")

def test_extra_dejson_property(self):
"""Test that extra_dejson property correctly deserializes JSON extra field."""
connection = Connection(
Expand Down