Skip to content

Conversation

@suprjinx
Copy link
Contributor

@suprjinx suprjinx commented Jul 18, 2025

The cluster_context passed into AsyncKubernetesHook is not passed through when load_kube_config_from_dict is called. This causes failures if you are running a KubernetesPodOperator task with deferrable=True and a cluster context that’s different to the default.

Ensuring the cluster_context is passed into the load_kube_config_from_dict method ensures the correct context is used for API calls

This is a duplicate of an auto-closed PR: #44522

related: https://github.com/G-Research/gr-oss/issues/1018


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 18, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Jul 18, 2025
@eladkal eladkal requested a review from romsharon98 July 18, 2025 19:50
@eladkal eladkal changed the title K8s hook load config Pass cluster context to AsyncKubernetesHook Jul 18, 2025
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM But I would love if someone who actually knows our k8s async can take a look at it.

@suprjinx
Copy link
Contributor Author

LGTM But I would love if someone who actually knows our k8s async can take a look at it.

Thanks @potiuk! any recommendation of who I should tag for review?

@potiuk
Copy link
Member

potiuk commented Jul 21, 2025

LGTM But I would love if someone who actually knows our k8s async can take a look at it.

Thanks @potiuk! any recommendation of who I should tag for review?

We usually don't tag people - they usually volunteer they are not being volunteered.

@potiuk potiuk merged commit 36fbb3f into apache:main Jul 24, 2025
85 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 24, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
* ensure cluster context is passed through

* reformat

---------

Co-authored-by: Alfred Davidson <alfie.davidson9@gmail.com>
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
* ensure cluster context is passed through

* reformat

---------

Co-authored-by: Alfred Davidson <alfie.davidson9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants