Pass cluster context into load_kube_config_from_dict #44522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
awdavidson
requested review from
hussein-awala and
jedcunningham
as code owners
awdavidson
force-pushed
the
k8s-hook-load-config
branch
from
6bde0cc to
66d79bb
Compare
eladkal
force-pushed
the
k8s-hook-load-config
branch
from
66d79bb to
150f2a4
Compare
amoghrajesh
reviewed
Dec 15, 2024
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Yeah sounds like a good idea and something that is needed as per https://kubernetes-asyncio.readthedocs.io/en/latest/kubernetes_asyncio.config.kube_config.html#kubernetes_asyncio.config.kube_config.load_kube_config
I would request for one more approval here as I am not an expert in this provider. @jedcunningham / @hussein-awala?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster_context passed into AsyncKubernetesHook is not passed through when load_kube_config_from_dict is called. This causes failures if you are running a KubernetesPodOperator task with deferrable=True and a cluster context that’s different to the default.
Ensuring the cluster_context is passed into the load_kube_config_from_dict method ensures the correct context is used for API calls
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.