-
Notifications
You must be signed in to change notification settings - Fork 16.4k
feature: Added support for Google cloud log sink management via google provider #52001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Added support for Google cloud log sink management via google provider #52001
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
shahar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising overall! Small comment regarding validation of templated fields.
@VladaZakharova - I'll be happy for additional feedback :)
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
5889af3 to
ee8bc9d
Compare
|
Hi |
video.mp4further below I have added some additional screenshot from manual dag testing. creating multiple log sink with different destination Please let me know if i have to do something else as Proof of work. |
shahar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done!
Waiting for @VladaZakharova 's approval to merge :)
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/tests/system/google/cloud/cloud_logging_sink/example_cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
8455f95 to
83e661b
Compare
System Test:-
|
83e661b to
2e67e19
Compare
|
@VladaZakharova I have made requested change. Could you please re-review? Added:- |
b88400b to
e8e6689
Compare
VladaZakharova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small comments left 😺
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/operators/cloud_logging_sink.py
Show resolved
Hide resolved
...rs/google/tests/system/google/cloud/cloud_logging_sink/example_cloud_logging_protobuf_obj.py
Outdated
Show resolved
Hide resolved
|
@VladaZakharova made requested change. Please check |
|
@VladaZakharova Just a friendly reminder to look at this. |
VladaZakharova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!










Issues/feature request link: #51929
This pull request introduces new operator in google provider.
With help of new operator airflow user now can create google cloud log sinks via airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.