Skip to content

Conversation

@paolofacchinetti
Copy link
Contributor

@paolofacchinetti paolofacchinetti commented Apr 24, 2025

closes: #49698

Since the webserver component is deprecated in Airflow 3.x.x, the existing ingress is not templated during chart deployment.

This PR adds an Ingress resource for the Airflow API Server in the Airflow Helm Chart.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 24, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@kaxil
Copy link
Member

kaxil commented Apr 28, 2025

@paolofacchinetti Could you add some simple tests similar to https://github.com/apache/airflow/blob/main/helm-tests/tests/helm_tests/webserver/test_ingress_web.py ?

Let me know if you need any help

@kaxil kaxil added this to the Airflow Helm Chart 1.17.0 milestone Apr 28, 2025
@paolofacchinetti
Copy link
Contributor Author

@kaxil done, since the new apiserver ingress is pretty much the same as the old webserver, I've just copied the tests and updated them. Let me know if that's enough.

tests run successfully with breeze testing helm-tests --test-type apiserver

@kaxil kaxil enabled auto-merge (squash) April 28, 2025 14:23
auto-merge was automatically disabled April 28, 2025 15:21

Head branch was pushed to by a user without write access

@paolofacchinetti
Copy link
Contributor Author

@kaxil had to break a comment into 2 lines to pass linting, all other CI jobs lgtm - let me know if theres anything else to be done and thanks for the review!

@kaxil kaxil enabled auto-merge (squash) April 28, 2025 20:03
@peter-cheon
Copy link

peter-cheon commented Apr 29, 2025

@paolofacchinetti

When testing, it was found that an addition related to webserver-config is necessary.
Other components already include the webserver-config section.
Without it, it's not possible to proceed with LDAP integration or similar configurations.

cc. @kaxil

@paolofacchinetti
Copy link
Contributor Author

@peter-cheon I'm not sure what you mean with "an addition related to webserver-config is necessary" and how it is related to the api-server ingress... is it something that can be done in another PR?

@kaxil
Copy link
Member

kaxil commented Apr 29, 2025

@paolofacchinetti

When testing, it was found that an addition related to webserver-config is necessary. Other components already include the webserver-config section. Without it, it's not possible to proceed with LDAP integration or similar configurations.

cc. @kaxil

Could you create a separate PR for that?

@kaxil
Copy link
Member

kaxil commented Apr 29, 2025

@paolofacchinetti I rebased your PR and fixed static checks in fa2b400 -- hopefully tests should pass now

@kaxil
Copy link
Member

kaxil commented Apr 29, 2025

One test failed but it is unrelated failure and known one. I'll retrigger it.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green... should we merge?

@peter-cheon
Copy link

@peter-cheon I'm not sure what you mean with "an addition related to webserver-config is necessary" and how it is related to the api-server ingress... is it something that can be done in another PR?

What I meant is that I will create a separate PR after the above PR has been merged.
Thank you.

@kaxil kaxil merged commit 19504ae into apache:main Apr 30, 2025
98 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 30, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingress Not Being Created in Airflow 3.0.0 Helm Chart

6 participants