Skip to content

Conversation

@Shashwatpandey4
Copy link
Contributor

@Shashwatpandey4 Shashwatpandey4 commented Apr 11, 2025

This PR adds support for the ORC source format to the GCSToBigQueryOperator.

Changes

  • Updated GCSToBigQueryOperator to accept source_format="ORC"
  • Added a unit test to validate ORC format works with external tables

This closes: #48624

Checklist

  • Code change includes tests
  • Verified DAG parsing and task execution locally
  • Added test: test_external_table_should_accept_orc_source_format

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 11, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 11, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bugraoz93
Copy link
Contributor

Thanks for the changes!

@bugraoz93 bugraoz93 requested a review from eladkal April 12, 2025 08:23
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like pre-commits need a rerun :)

@Shashwatpandey4
Copy link
Contributor Author

i re-run the pre-commits @bugraoz93

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a rebase now because there is a commit from already merged PR. Try rebase and force push. Requesting a change to prevent merge the same commit

@Shashwatpandey4
Copy link
Contributor Author

done @bugraoz93

@bugraoz93
Copy link
Contributor

Screenshot from 2025-04-13 20-01-35

@Shashwatpandey4 I still can see Vincents' commit message :( Maybe easiest is creating a new PR and close this one

@Shashwatpandey4
Copy link
Contributor Author

@bugraoz93 here's a new pr with only my changes in it 49188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for ORC in GCSToBigQueryOperator

3 participants