Skip to content

Add ORC support to GCSToBigQueryOperator and test for external tables #49143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shashwatpandey4 wants to merge 1 commit into from
Closed

Add ORC support to GCSToBigQueryOperator and test for external tables #49143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"GOOGLE_SHEETS",
"DATASTORE_BACKUP",
"PARQUET",
"ORC",
]


Expand Down
44 changes: 44 additions & 0 deletions providers/google/tests/unit/google/cloud/transfers/test_gcs_to_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,6 +1565,50 @@ def test_get_openlineage_facets_on_complete_full_table_multiple_gcs_uris(self, h
}
assert lineage.job_facets == {}

@mock.patch(GCS_TO_BQ_PATH.format("BigQueryHook"))
def test_external_table_should_accept_orc_source_format(self, hook):
hook.return_value.insert_job.side_effect = [
MagicMock(job_id=REAL_JOB_ID, error_result=False),
REAL_JOB_ID,
]
hook.return_value.generate_job_id.return_value = REAL_JOB_ID
hook.return_value.split_tablename.return_value = (PROJECT_ID, DATASET, TABLE)

operator = GCSToBigQueryOperator(
task_id=TASK_ID,
bucket=TEST_BUCKET,
source_objects=TEST_SOURCE_OBJECTS,
destination_project_dataset_table=TEST_EXPLICIT_DEST,
schema_fields=SCHEMA_FIELDS,
write_disposition=WRITE_DISPOSITION,
external_table=True,
project_id=JOB_PROJECT_ID,
source_format="ORC",
)

operator.execute(context=MagicMock())

hook.return_value.create_empty_table.assert_called_once_with(
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
table_resource={
"tableReference": {
"projectId": PROJECT_ID,
"datasetId": DATASET,
"tableId": TABLE,
},
"externalDataConfiguration": {
"autodetect": True,
"sourceFormat": "ORC",
"sourceUris": [f"gs://{TEST_BUCKET}/{TEST_SOURCE_OBJECTS}"],
"compression": "NONE",
"ignoreUnknownValues": False,
"schema": {"fields": SCHEMA_FIELDS},
},
},
)


@pytest.fixture
def create_task_instance(create_task_instance_of_operator, session):
Expand Down