-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add extra secret annotations to most secrets #48890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra secret annotations to most secrets #48890
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
4ab47fc to
8a742e6
Compare
8a742e6 to
6543090
Compare
6543090 to
05bb474
Compare
|
@potiuk approved running CI a few days ago, it seems like there was an error in generating requirements.txt: https://github.com/apache/airflow/actions/runs/14385261556/job/40784592715 But AFAIK that should be unrelated to the helm chart? Since I didn't add any dependencies. I tried rebasing off of main to see if that would help (if it was an unrelated error that has since been fixed). But if you think this might be related to my PR and I need to investigate more, please let me know! Thank you! |
|
It seems like all the checks pass now! @dstandish @jedcunningham @hussein-awala would you be up for reviewing this soon? |
Hello! I was wondering if I might be able to get feedback on this soon? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively - thoughts on just adding a common AirflowSecretsAnnotations value which is added to all secrets? Something similar is already supported for pods:
Lines 290 to 292 in 4789fc2
| # Extra annotations to apply to all | |
| # Airflow pods | |
| airflowPodAnnotations: {} |
Will let the maintainers weigh in here with their best practices.
We could! I thought that maybe people would want to add different annotations to different secrets. But for our use case, we want to add the same annotation to them all (turning off versioning in our deploy tool), so I'm okay with either approach. I'll defer to the maintainers. |
Happy to take a PR for that as well :) |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Thanks @sarah-reddit! Congrats on your first PR 🎉! |
|
@jedcunningham Thanks so much for your review! Very exciting! :) |
This adds annotations to the following secret objects:
Motivation:
Our deploy tool by default versions secrets. This forces us to fork this helm chart and modify it to adding annotations to disable versioning. This would take us a step closer to not having to do that anymore. (Relevant: #29910)
This PR was mostly inspired by #33340.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.