-
Notifications
You must be signed in to change notification settings - Fork 16.4k
add annotations to configmaps #29910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to install pre-commit to fix static checks
|
@hussein-awala I installed pre-commit to fix static checks and committed changes. |
There are few more suggestions from @hussein-awala |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{- with .Values.labels }} | ||
| {{ toYaml . | indent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this?
| {{- with .Values.labels }} | |
| {{ toYaml . | indent 4 }} | |
| {{- end }} | |
| {{- with .Values.labels }} | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} |
| {{- with .Values.statsd.configMapAnnotations }} | ||
| annotations: | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add indent
| {{- with .Values.statsd.configMapAnnotations }} | |
| annotations: | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} | |
| {{- with .Values.statsd.configMapAnnotations }} | |
| annotations: | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} |
| {{- with .Values.labels }} | ||
| {{ toYaml . | indent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here:
| {{- with .Values.labels }} | |
| {{ toYaml . | indent 4 }} | |
| {{- end }} | |
| {{- with .Values.labels }} | |
| {{- toYaml . | nindent 4 }} | |
| {{- end } |
| {{- with .Values.webserver.configMapAnnotations }} | ||
| annotations: | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add indent
| {{- with .Values.webserver.configMapAnnotations }} | |
| annotations: | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} | |
| {{- with .Values.webserver.configMapAnnotations }} | |
| annotations: | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
@hussein-awala I will take this up as we also need some custom labels/annotations onto our configmaps. |
This adds annotations to the following configmap objects:
Webserver
StatsD
Motivation:
We use spinnaker to deploy this helm chart, however spinnaker by default versions configmaps. This forces us to fork this helm chart and modify it to work with spinnaker, by adding annotations to disable spinnaker versioning. This would take us a step closer to not having to do that anymore.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.