Update pgbouncer to 1.23.1 and pgbouncer_exporter to 0.18.0 in helm chart

[Jarvl]

This PR bumps pgbouncer_exporter to version v0.18.0 and decrements pgbouncer to 1.23.1.

The latest version 0.18.0 of pgbouncer_exporter only provides support up to pgbouncer 1.23.1, as pgbouncer 1.24.0 introduces new stats that cause errors within pgbouncer_exporter. Currently, the latest images published for the helm chart are pgbouncer 1.24.0 airflow-pgbouncer-2025.01.10-1.24.0 and pgbouncer_exporter v0.17.0 airflow-pgbouncer-exporter-2024.06.18-0.17.0, which are incompatible with each other as outlined in #47295.

Until pgbouncer_exporter is updated to support these new metrics, the helm chart should use compatible versions of the libraries.

closes: #47295

New pgbouncer image: airflow-pgbouncer-2025.03.05-1.23.1
New pgbouncer_exporter image: airflow-pgbouncer-exporter-2025.03.05-0.18.0

This PR required changes to the pgbouncer build script and Dockerfile to support tag names that do not consistently correspond with the version name.

• Example: https://github.com/pgbouncer/pgbouncer/releases/tag/pgbouncer_1_23_1-fixed

Note: pgbouncer_exporter v0.18.0 also increments the go version used to 1.23, see: jbub/pgbouncer_exporter@479710b. The expected go version is bumped here to 1.23.7 here to support this change.

---

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[Jarvl]

@potiuk tagging you since you pushed the image for the last version bump to pgbouncer_exporter in #40303

[potiuk]

Yep. I am just on it :)

[potiuk]

ok. Pushed the image. apache/airflow:airflow-pgbouncer-exporter-2025.03.05-0.18.0 - can you please modfy helm-chart and change the defaults?

[Jarvl]

ok. Pushed the image. apache/airflow:airflow-pgbouncer-exporter-2025.03.05-0.18.0 - can you please modfy helm-chart and change the defaults?

To clarify - do you mean as part of this PR or a separate PR?

[potiuk]

As part of this PR is best :)

[potiuk]

Let's see if it passes the tests :)

[potiuk]

added missing EOL

[Jarvl]

Just tried the new image alongside pgbouncer 1.24, still getting the same error.

It looks like v0.18.0 of pgbouncer_exporter only provides support up to pgbouncer 1.23, so what's in my PR description currently is inaccurate. This will not resolve the errors noted in #47295.

I created an issue in the upstream library to address: jbub/pgbouncer_exporter#34

How do we want to proceed? It's not going to be as simple as performing this upgrade to provide support for pgbouncer 1.24 since the upstream needs updated with support.

One option could be to proceed with this PR, then decrement the pgbouncer version in the helm chart to 1.23 so there are no longer incompatibilities. Or at least build an image for pgbouncer 1.23. Then once pgbouncer_exporter has adequate support we can bump that to a newer version in the helm chart.

Edit: To clarify, there is not an image built for pgbouncer 1.23 (it was incremented from 1.22 -> 1.24 in #45542).

[Jarvl]

Just tried the new image alongside pgbouncer 1.24, still getting the same error.

It looks like v0.18.0 of pgbouncer_exporter only provides support up to pgbouncer 1.23, so what's in my PR description currently is inaccurate. This will not resolve the errors noted in #47295.

I created an issue in the upstream library to address: jbub/pgbouncer_exporter#34

How do we want to proceed? It's not going to be as simple as performing this upgrade to provide support for pgbouncer 1.24 since the upstream needs updated with support.

One option could be to proceed with this PR, then decrement the pgbouncer version in the helm chart to 1.23 so there are no longer incompatibilities. Or at least build an image for pgbouncer 1.23. Then once pgbouncer_exporter has adequate support we can bump that to a newer version in the helm chart.

Edit: To clarify, there is not an image built for pgbouncer 1.23 (it was incremented from 1.22 -> 1.24 in #45542).

I updated my PR description to reflect what I noted here.

[potiuk]

Let's decrease it to 1.23 in this PR

[potiuk]

With some comments left and link to the issue you opened -> then I can build and push the image - initially it will fail when you make the change but then I can push the image and restart failing jobs to pick up the new image

[Jarvl]

Let's decrease it to 1.23 in this PR

How comfortable are we with doing this and potentially introducing a breaking change into the helm chart? pgbouncer 1.24 introduces new features and configs so decrementing the version in the helm chart could be an unexpected breaking change for people using the defaults.

[potiuk]

I think we never released chart with 1.24

[potiuk]

We have not released chart for a looooong time.

[Jarvl]

I think we never released chart with 1.24

Ah good point, I should have checked the release notes!

[Jarvl]

Note that the pgbouncer Dockerfile needed changes to support the tag name used upstream so those changes are included in 7457aa6.

For example:
https://github.com/pgbouncer/pgbouncer/releases/tag/pgbouncer_1_23_1-fixed

Didn't test that the build works locally though, still working on getting my dev environment set up.

[Jarvl]

Note that the pgbouncer Dockerfile needed changes to support the tag name used upstream so those changes are included in 7457aa6.

For example: https://github.com/pgbouncer/pgbouncer/releases/tag/pgbouncer_1_23_1-fixed

Didn't test that the build works locally though, still working on getting my dev environment set up.

I validated locally that the build_and_push.sh script works as intended 👍

[potiuk]

Built and pushed, approved workflows

[Jarvl]

@potiuk Who would be the best person to ping for a review on this PR?

[potiuk]

Me :)

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[Jarvl]

Me :)

Thank you so much for your help and attention!