Skip to content

Conversation

@goktugkose
Copy link
Contributor

@goktugkose goktugkose commented Jan 10, 2025

As of version 1.23.0, pgBouncer introduced support for rolling restarts and version 1.24.0 is also introduced with several improvements and fixes. This feature allows users to seamlessly restart PgBouncer instances without disrupting active connections. For Airflow users managing PgBouncer on Kubernetes, this enhancement simplifies maintenance and upgrades, ensuring high availability and minimal downtime for critical workflows.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

As of version 1.23.0, pgBouncer introduced support for rolling restarts. This feature allows users to seamlessly restart PgBouncer instances without disrupting active connections. For Airflow users managing PgBouncer on Kubernetes, this enhancement simplifies maintenance and upgrades, ensuring high availability and minimal downtime for critical workflows.
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 10, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Jan 10, 2025
@potiuk
Copy link
Member

potiuk commented Jan 10, 2025

I built and pushed the image, running the tests to make sure it works in our K8S tests

@potiuk
Copy link
Member

potiuk commented Jan 10, 2025

Thanks for creating the PR @goktugkose

@potiuk
Copy link
Member

potiuk commented Jan 10, 2025

Random unrelated test failing. Merging. Thanks for the PR.

@potiuk potiuk merged commit 7dec7e8 into apache:main Jan 10, 2025
62 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 10, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@goktugkose
Copy link
Contributor Author

@potiuk Thank you so much for the quick response! I hope this contribution proves useful for the community. It's always great to collaborate and improve together ❤️

karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jan 13, 2025
As of version 1.23.0, pgBouncer introduced support for rolling restarts. This feature allows users to seamlessly restart PgBouncer instances without disrupting active connections. For Airflow users managing PgBouncer on Kubernetes, this enhancement simplifies maintenance and upgrades, ensuring high availability and minimal downtime for critical workflows.

Co-authored-by: Salih Göktuğ Köse <goktug.kose@trendyol.com>
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
As of version 1.23.0, pgBouncer introduced support for rolling restarts. This feature allows users to seamlessly restart PgBouncer instances without disrupting active connections. For Airflow users managing PgBouncer on Kubernetes, this enhancement simplifies maintenance and upgrades, ensuring high availability and minimal downtime for critical workflows.

Co-authored-by: Salih Göktuğ Köse <goktug.kose@trendyol.com>
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
As of version 1.23.0, pgBouncer introduced support for rolling restarts. This feature allows users to seamlessly restart PgBouncer instances without disrupting active connections. For Airflow users managing PgBouncer on Kubernetes, this enhancement simplifies maintenance and upgrades, ensuring high availability and minimal downtime for critical workflows.

Co-authored-by: Salih Göktuğ Köse <goktug.kose@trendyol.com>
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
As of version 1.23.0, pgBouncer introduced support for rolling restarts. This feature allows users to seamlessly restart PgBouncer instances without disrupting active connections. For Airflow users managing PgBouncer on Kubernetes, this enhancement simplifies maintenance and upgrades, ensuring high availability and minimal downtime for critical workflows.

Co-authored-by: Salih Göktuğ Köse <goktug.kose@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants