-
Notifications
You must be signed in to change notification settings - Fork 16.4k
gitSync: add extraEnvFrom to git-sync containers to support proxy settings from k8s secret #39031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitSync: add extraEnvFrom to git-sync containers to support proxy settings from k8s secret #39031
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd much rather we move gitSync.env to accept V1EnvVars vs restricting it artificially like we are now.
@rasulkarimov, can you give that approach a shot instead?
|
@jedcunningham Therefore, I have updated the PR to allow envFrom in git_sync_container. This will enable us to provide proxy settings with credentials to the git-sync container from a Kubernetes secret(without restricting it artificially). |
|
look good, can you fix current tests to validate your changes? |
f0abc8c to
3efd5a0
Compare
Thank you! Fixed tests. |
3efd5a0 to
f634cb4
Compare
Can we merge this PR? |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also i think since it is a pretty trivial case, do we also document it?
232022c to
b33f362
Compare
can we merge? |
This reverts commit f38fb21a0c1373d389b7c5d979a75c912196d183.
This reverts commit d25fc2f7585edac96d40cada6217328cbdfd3e18.
…ehind corporate proxy" This reverts commit 905991b1be7c85ee968d2d4d113b2d1ebbb6aaaa.
1fe7697 to
b304be4
Compare
|
cc @jedcunningham as you marked request changes |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Thanks @rasulkarimov! Sorry for the slow merge. Congrats on your first commit 🎉 |
This PR introduces support for proxy settings in the gitSync containers to accommodate scenarios where the git repository is located behind a corporate proxy server. The proxy settings can be configured in a Kubernetes secret with keys HTTPS_PROXY, HTTP_PROXY, and NO_PROXY. These settings are then accessed via the 'dags.gitSync.proxySettingsSecret' variable, which provides them as environment variables for the gitSync containers.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.