Skip to content

gitSync: allow gitSync.env to take a env var from a secret reference #42024

@connorlwilkes

Description

@connorlwilkes

Description

Currently the schema for gitSync.env does not allow you to define env from secrets like:

env:
        - name: GIT_SYNC_USERNAME
          valueFrom:
            secretKeyRef:
              name: gitsync-secret
              key: username
        - name: GITSYNC_USERNAME
          valueFrom:
            secretKeyRef:
              name: gitsync-secret
              key: username
        - name: GIT_SYNC_PASSWORD
          valueFrom:
            secretKeyRef:
              name: gitsync-secret
              key: pwd
        - name: GITSYNC_PASSWORD
          valueFrom:
            secretKeyRef:
              name: gitsync-secret
              key: pwd

This is because the schema is overly restrictive and doesn't just reference the upstream V1EnvVar. See: https://github.com/apache/airflow/blob/main/chart/values.schema.json#L8557-L8583

Use case/motivation

No response

Related issues

#39031

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:helm-chartAirflow Helm Chartkind:featureFeature Requestsneeds-triagelabel for new issues that we didn't triage yet

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions