Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check supported DP features in initialization #2571

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Aug 10, 2021

If any of required DP features is not supported, agent will log the
error and crash, instead of keeping running which hides the error from
users, leading to more effort to troubleshoot traffic issues.

Signed-off-by: Quan Tian qtian@vmware.com

Fixes #1745

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request fixes 1 alert when merging a3461d5 into fe4457f - view on LGTM.com

fixed alerts:

  • 1 for Command built from user-controlled sources

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #2571 (8c201c1) into main (fe4457f) will decrease coverage by 17.97%.
The diff coverage is 38.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2571       +/-   ##
===========================================
- Coverage   60.09%   42.11%   -17.98%     
===========================================
  Files         281      152      -129     
  Lines       22243    18458     -3785     
===========================================
- Hits        13366     7773     -5593     
- Misses       7467     9986     +2519     
+ Partials     1410      699      -711     
Flag Coverage Δ
kind-e2e-tests ?
unit-tests 42.11% <38.77%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/agent.go 19.32% <0.00%> (-30.79%) ⬇️
pkg/ovs/ovsctl/interface.go 0.00% <ø> (ø)
pkg/ovs/ovsctl/appctl.go 20.65% <61.29%> (-9.51%) ⬇️
pkg/ovs/openflow/default.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/util/runtime/runtime.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/config/node_config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/apis/controlplane/v1beta1/register.go 0.00% <0.00%> (-92.86%) ⬇️
pkg/ovs/openflow/logs.go 9.52% <0.00%> (-90.48%) ⬇️
pkg/apis/controlplane/register.go 0.00% <0.00%> (-90.00%) ⬇️
... and 231 more

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request fixes 1 alert when merging 6c2fb5b into fe4457f - view on LGTM.com

fixed alerts:

  • 1 for Command built from user-controlled sources

@tnqn
Copy link
Member Author

tnqn commented Aug 10, 2021

/test-all

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message: "to troubleshooting" -> "to troubleshoot"

pkg/ovs/ovsctl/appctl.go Outdated Show resolved Hide resolved
Copy link
Member Author

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message: "to troubleshooting" -> "to troubleshoot"

Done, thanks!

pkg/ovs/ovsctl/appctl.go Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request fixes 1 alert when merging bc74596 into fe4457f - view on LGTM.com

fixed alerts:

  • 1 for Command built from user-controlled sources

antoninbas
antoninbas previously approved these changes Aug 11, 2021
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/agent/agent.go Outdated Show resolved Hide resolved
If any of required DP features is not supported, agent will log the
error and crash, instead of keeping running which hides the error from
users, leading to more effort to troubleshoot traffic issues.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn
Copy link
Member Author

tnqn commented Aug 11, 2021

/test-all

@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2021

This pull request fixes 1 alert when merging 5bae336 into fe4457f - view on LGTM.com

fixed alerts:

  • 1 for Command built from user-controlled sources

@antoninbas antoninbas merged commit 20fb980 into antrea-io:main Aug 11, 2021
annakhm pushed a commit to annakhm/antrea that referenced this pull request Aug 16, 2021
If any of required DP features is not supported, agent will log the
error and crash, instead of keeping running which hides the error from
users, leading to more effort to troubleshoot traffic issues.

Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent should go crash if installation of essential flows failed
4 participants