-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Agent crash if installation of essential flows failed #1787
Conversation
Importing the changes ofnet#16 to fix the issue. Fixed antrea-io#1745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1787 +/- ##
=======================================
Coverage ? 63.39%
=======================================
Files ? 192
Lines ? 16363
Branches ? 0
=======================================
Hits ? 10373
Misses ? 4932
Partials ? 1058
Flags with carried forward coverage won't be shown. Click here to find out more. |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to my test, this PR didn't work as expected.
|
@tnqn, I tested in
Does your testbed have a different from it? |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days |
Codecov Report
@@ Coverage Diff @@
## main #1787 +/- ##
=======================================
Coverage ? 63.27%
=======================================
Files ? 192
Lines ? 18805
Branches ? 0
=======================================
Hits ? 11899
Misses ? 5795
Partials ? 1111
Flags with carried forward coverage won't be shown. Click here to find out more. |
@jianjuns No, this change doesn't resolve the original issue. There is still a chance that some DP feature is missing but the installation of essential flows doesn't fail. We figured out the reason but there is no simply way to detect whether a mod-flow message in a bundle is accepted by DP. |
Importing the changes wenyingd/ofnet#16 to fix the issue.
Fixed #1745.