Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent should go crash if installation of essential flows failed #1745

Closed
weiqiangt opened this issue Jan 14, 2021 · 2 comments · Fixed by #2571
Closed

Agent should go crash if installation of essential flows failed #1745

weiqiangt opened this issue Jan 14, 2021 · 2 comments · Fixed by #2571
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@weiqiangt
Copy link
Contributor

Describe the bug
The AntreaAgent keeps running even it met flow installation errors. For E.g. AntreaProxy needs kernel version ≥ 4.6 and thus in the lower version kernel any flow installation with ct(nat) will fail which leads to several key flows in table 30 not exist. The AntreaAgent should crash instead of keeping running which misleads users.

To Reproduce
Deploy Antrea on Node with kernel version lower than 4.6. There is no flow in table 30.

Expected
The Agent should crash if any essential flow can not be installed.

Actual behavior
The Agent keeps running.

Additional context
#1652

@weiqiangt weiqiangt added the kind/bug Categorizes issue or PR as related to a bug. label Jan 14, 2021
@weiqiangt weiqiangt self-assigned this Jan 14, 2021
@antoninbas antoninbas added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 14, 2021
weiqiangt added a commit to weiqiangt/antrea that referenced this issue Jan 27, 2021
Importing the changes ofnet#16 to fix the issue.

Fixed antrea-io#1745
@weiqiangt
Copy link
Contributor Author

In github.com/contiv/lib!openflow@v0.0.0-20201014051314-c1702744526c/util/stream.go:71

	go m.outbound()
	go m.inbound()
	for i := 0; i < numParserGoroutines; i++ {
		go m.parse()
	}

There are multiple parsers that make messages lose the order, and thus we see that the BundleClose message may be received earlier than BundleAddErrorMesage.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment, or this will be closed in 180 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
2 participants